Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-6724

Override Spring class to improve startup performance

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-rc2
    • Fix Version/s: 2.1.0-m1, 2.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-3760Improve overridability of UiDocumentServiceImpl
      KULRICE-2294Combine Rice Spring Contexts into a single Spring context
      KULRICE-8960LookupUtils getSearchResultsLimit Performance Improvement
      KULRICE-8946A few small things that can improve KRAD performance
      KULRICE-9042Spring - Performance
      KULRICE-8957CloneUtils getFields Performance Improvement
      KULRICE-3643Make private methods in document-related classes protected to improve overridability
      KULRICE-1130improve performance of xml ingestion
      KULRICE-2516Updates to support KFS Spring context merge
      KULRICE-8448Improve Role Performance
    • Rice Module:
      Rice Core
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Despite what the Spring JIRA queue says, they did not fix the performance problem related to large Spring configuration sets. (Such as the KFS data dictionary.)

      I have attached the replacement for the problem class. (Adapted from my fix which was present in KFS for releases 4 and 4.1 for the new Spring 3.1 release.)

      I will be checking this into the KFS project as a matter of course, as it halves the startup time of the system.

      If you add this class to Rice, you will also need to add the dependency below for compilation:

          <dependency>
            <groupId>javax.inject</groupId>
            <artifactId>javax.inject</artifactId>
            <version>1</version>
            <scope>provided</scope> 
          </dependency>
      

        Issue Links

          Activity

          Hide
          Jessica Coltrin (Inactive) added a comment -

          adding to 2.1 milestone 1 since the fix is already here from Jonathan, but it seen too impactful & not critical to put into 2.0 at this late date.

          Show
          Jessica Coltrin (Inactive) added a comment - adding to 2.1 milestone 1 since the fix is already here from Jonathan, but it seen too impactful & not critical to put into 2.0 at this late date.
          Hide
          Sona Sona (Inactive) added a comment -

          Created a pre-commit review.

          Show
          Sona Sona (Inactive) added a comment - Created a pre-commit review.
          Hide
          Sona Sona (Inactive) added a comment -

          I tested the changes and the server startup time has reduced by almost half(from ~59 sec to ~34 sec).

          Show
          Sona Sona (Inactive) added a comment - I tested the changes and the server startup time has reduced by almost half(from ~59 sec to ~34 sec).
          Hide
          Travis Schneeberger added a comment -

          What is the Spring JIRA you are referring to? If there isn't an open one, we should open one with Spring Source since this fix sounds like it belongs in Spring not Rice. If Spring doesn't think the issue exists, it would be interesting to understand why.

          Show
          Travis Schneeberger added a comment - What is the Spring JIRA you are referring to? If there isn't an open one, we should open one with Spring Source since this fix sounds like it belongs in Spring not Rice. If Spring doesn't think the issue exists, it would be interesting to understand why.
          Hide
          Jonathan Keller added a comment -
          Show
          Jonathan Keller added a comment - It's this one: https://jira.springsource.org/browse/SPR-8318

            People

            • Assignee:
              Sona Sona (Inactive)
              Reporter:
              Jonathan Keller
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel