Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-6952

Action list performance issue with "Current Route Node(s)" preference enabled

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.0.3, 2.0
    • Fix Version/s: 2.0.2, 2.1
    • Component/s: Performance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5576Rice Dev: Action List Preferences, checking the Current Route Node(s) causes error
      KULRICE-12883Action List: Move Preferences Screens to KRAD
      KULRICE-5908Rice Dev: Action List Preferences, selecting a color for disapproved or processed not working
      KULRICE-7531Action List does not use backdoored user's Action List preferences
      KULRICE-7714Performance improvements in regards to workflow data access
      KULRICE-4479Clicking the action list's "take actions" button can interfere with document and route log popups
      KULRICE-5578Rice Dev: Action List Preferences, incorrect error messaging
      KULRICE-2822issues with action list
      KULRICE-7097No current api method to get fill list of current and non-current Actions Taken
      KULRICE-7496Backport performance optimizations for how action list caching is handled from KULRICE-6849
    • Rice Module:
      KEW
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      We have some users who use their action list with 500 items per page with the "Current Route Node(s)" preference enabled. This is a problem because the overhead required to load the full RouteNodeInstance objects related to 500 action items tends to take longer than it should. I've attached a patch here which adds a pair of new methods to the RouteNodeService which looks up the names of active or terminal route notes rather than fetching the full RouteNodeInstances and then pulling the name off of those. I implemented the methods in the RouteNodeDAO using a JDBC template to avoid the OJB issue here, but if there is a better way to go about it please change the code to correct it.

        Issue Links

          Activity

          Hide
          Jessica Coltrin (Inactive) added a comment -

          Since there's a patch file included, assigning to 2.1 for review by 2.1 DMs.

          Show
          Jessica Coltrin (Inactive) added a comment - Since there's a patch file included, assigning to 2.1 for review by 2.1 DMs.
          Hide
          Peter Giles (Inactive) added a comment -

          Isn't this pretty similar to the ActionItemActionListExtension optimization? I suspect it could be handled similarly where an extension object is mapped that doesn't retrieve the references. That way we could avoid the straight SQL.

          Show
          Peter Giles (Inactive) added a comment - Isn't this pretty similar to the ActionItemActionListExtension optimization? I suspect it could be handled similarly where an extension object is mapped that doesn't retrieve the references. That way we could avoid the straight SQL.
          Hide
          Kristina Taylor (Inactive) added a comment -

          Marking as 2.1 as well as per discussion with Jessica.

          Show
          Kristina Taylor (Inactive) added a comment - Marking as 2.1 as well as per discussion with Jessica.
          Hide
          Jeff Ruch added a comment - - edited

          Determined correct approach. Applied the patch. Added missing return value for getCurrentNodeNames(). Tested successfully on MySQL. Reviewed code for database vendor specific SQL.

          Show
          Jeff Ruch added a comment - - edited Determined correct approach. Applied the patch. Added missing return value for getCurrentNodeNames(). Tested successfully on MySQL. Reviewed code for database vendor specific SQL.
          Hide
          Jeff Ruch added a comment - - edited

          Committed updated patch in 2.02. Will be merged to 2.1 on Friday.

          Show
          Jeff Ruch added a comment - - edited Committed updated patch in 2.02. Will be merged to 2.1 on Friday.

            People

            • Assignee:
              Jeff Ruch
              Reporter:
              James Bennett
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel