Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-6952

Action list performance issue with "Current Route Node(s)" preference enabled

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.0.3, 2.0
    • Fix Version/s: 2.0.2, 2.1
    • Component/s: Performance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KEW
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      We have some users who use their action list with 500 items per page with the "Current Route Node(s)" preference enabled. This is a problem because the overhead required to load the full RouteNodeInstance objects related to 500 action items tends to take longer than it should. I've attached a patch here which adds a pair of new methods to the RouteNodeService which looks up the names of active or terminal route notes rather than fetching the full RouteNodeInstances and then pulling the name off of those. I implemented the methods in the RouteNodeDAO using a JDBC template to avoid the OJB issue here, but if there is a better way to go about it please change the code to correct it.

        Attachments

          Issue Links

            Activity

            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            Since there's a patch file included, assigning to 2.1 for review by 2.1 DMs.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - Since there's a patch file included, assigning to 2.1 for review by 2.1 DMs.
            Hide
            gilesp Peter Giles (Inactive) added a comment -

            Isn't this pretty similar to the ActionItemActionListExtension optimization? I suspect it could be handled similarly where an extension object is mapped that doesn't retrieve the references. That way we could avoid the straight SQL.

            Show
            gilesp Peter Giles (Inactive) added a comment - Isn't this pretty similar to the ActionItemActionListExtension optimization? I suspect it could be handled similarly where an extension object is mapped that doesn't retrieve the references. That way we could avoid the straight SQL.
            Hide
            kbtaylor Kristina Taylor (Inactive) added a comment -

            Marking as 2.1 as well as per discussion with Jessica.

            Show
            kbtaylor Kristina Taylor (Inactive) added a comment - Marking as 2.1 as well as per discussion with Jessica.
            Hide
            jruch Jeff Ruch added a comment - - edited

            Determined correct approach. Applied the patch. Added missing return value for getCurrentNodeNames(). Tested successfully on MySQL. Reviewed code for database vendor specific SQL.

            Show
            jruch Jeff Ruch added a comment - - edited Determined correct approach. Applied the patch. Added missing return value for getCurrentNodeNames(). Tested successfully on MySQL. Reviewed code for database vendor specific SQL.
            Hide
            jruch Jeff Ruch added a comment - - edited

            Committed updated patch in 2.02. Will be merged to 2.1 on Friday.

            Show
            jruch Jeff Ruch added a comment - - edited Committed updated patch in 2.02. Will be merged to 2.1 on Friday.

              People

              • Assignee:
                jruch Jeff Ruch
                Reporter:
                jawbenne James Bennett
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: