Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-7112

when copying a document with notes, the original document's notes are lost because new copied document's notes note ids are also copied..

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.1.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7580BO Notes are not brought from original document to the new document.
      KULRICE-7420The Copy function is creating a history (within the Notes and Attachments section) of all copied doc numbers linked to the original 'copied' document
      KULRICE-514missing DDL, DML for some notes tables
      KULRICE-12327Cannot delete BO note when document is initialized
      KULRICE-8290Reload on Note Text (13)
      KULRICE-881Annotation lost when note is saved
      KULRICE-7415BO Notes do not save through notes tag
      KULRICE-10361Adding document notes broken
      KULRICE-5015Fix problem with document routing and Notes
      KULRICE-13911Document Operation screen issues Notes/ActionRequestParentId/ActionRequestTakenId
    • Rice Module:
      Rice Core
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Notes and Attachments: when a document is copied with notes and attachments, the newly copied document gets the same notes with same note id (primary key). When the newly copied docuemnt is saved the notes are saved with the new document's remoteObjectId which is the key to get the notes for a given document. What this is doing is that the notes on the first document is lost and are now linked to the second copied document. In copying notes, a new note should be created with a note id from the sequence and then copy the data over to the new note record and add to the collection that gets put on the document.

        Issue Links

          Activity

          Hide
          Muddu Salem added a comment -

          I have tested in 4.1.1 testdrive (rice 1.0.3), the notes and attachments are not copied from the original document to the new document. We want to maintain the same behavior in KFS 5.0. Sorry for all the confusion but the notes and attachments should NOT be copied except to create a new notes created on the copied documents with the message "Copied from original document: xxx". I will get the exact message that I have implemented in the overriddedn copy() method.

          Show
          Muddu Salem added a comment - I have tested in 4.1.1 testdrive (rice 1.0.3), the notes and attachments are not copied from the original document to the new document. We want to maintain the same behavior in KFS 5.0. Sorry for all the confusion but the notes and attachments should NOT be copied except to create a new notes created on the copied documents with the message "Copied from original document: xxx". I will get the exact message that I have implemented in the overriddedn copy() method.
          Hide
          Muddu Salem added a comment -

          The message for the note created is "Copied from document: " + documentNumber;

          Show
          Muddu Salem added a comment - The message for the note created is "Copied from document: " + documentNumber;
          Hide
          Jeremy Hanson added a comment -

          Looks like creating the new note is KFS code. In FinancialSystemTransactionalDocument.createNoteForCopy. I think I have this fixed for Maintenance documents, but probably not for transactional docs yet. I think I know what I need to do though, so just need to find the correct spot to do it.

          Show
          Jeremy Hanson added a comment - Looks like creating the new note is KFS code. In FinancialSystemTransactionalDocument.createNoteForCopy. I think I have this fixed for Maintenance documents, but probably not for transactional docs yet. I think I know what I need to do though, so just need to find the correct spot to do it.
          Hide
          Muddu Salem added a comment -

          I created createNoteForCopy method on KFS to just remove the copied notes and create a new one. I will refactor that code when rice side is fixed for this task.

          Show
          Muddu Salem added a comment - I created createNoteForCopy method on KFS to just remove the copied notes and create a new one. I will refactor that code when rice side is fixed for this task.
          Hide
          Jessica Coltrin (Inactive) added a comment -

          release notes are generated. closing issues.

          Show
          Jessica Coltrin (Inactive) added a comment - release notes are generated. closing issues.

            People

            • Assignee:
              Jeremy Hanson
              Reporter:
              Muddu Salem
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel