Details
-
Type:
Bug Fix
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.2.0-m4
-
Fix Version/s: Not version specific
-
Component/s: Development, User Experience (UX), User Interface
-
Security Level: Public (Public: Anyone can view)
-
Labels:None
-
Epic Link:
-
Rice Module:KRAD
-
Application Requirement:KS
-
KAI Review Status:Not Required
-
KTI Review Status:Not Required
Description
1) Styles should be defined in the theme "branches", not in the bean/class' parent/base "root" that then applies across all themes. KRAD support for themes (and supply of at least 2 that applications can choose from/inherit) is important, demonstrating how easy it is for applications and institutions to customize through KRAD.
For example, in 2.2, the KNS L&F has inherited various font and other visual treatments from the KS L&F specs, whereas in 2.0, these were at the theme level (respecting the KNS L&F choices). These should be corrected to use the KNS L&F or the KS L&F, as appropriate, depending on the selected theme.
2) Both themes should use px for margins and padding, but not for fonts (use ems or % for fonts). There are several elements that have been changed in 2.2 to use px for fonts. These should be corrected (for example, in all headings for both themes).
3) Both themes should include a fall-back list of font families for every element (there should be no element that lists only one font family. For example, list "Helvetica, Arial, sans-serif" or "Times New Roman, Georgia, serif" instead of "Helvetica" or "Times New Roman". Without a fall-back list, there can be problems with font size inheritance when people use some methods to enlarge font sizing.
See attachment for example where we have only one font defined for H2s in the portal, whereas all the other UI text elements include a fall-back list.
Attachments
Issue Links
- cloned from
-
KULRICE-6671 UI Framework - Framework code improvements
-
- Closed
-
Activity
Field | Original Value | New Value |
---|---|---|
Link |
This issue cloned from |
Summary | UI Framework - Bean and CSS class framework support for multiple themes | UI Framework - CSS class hierarchy - support for multiple themes -cleanup |
Issue Type | New Feature [ 2 ] | Bug Fix [ 1 ] |
Description |
Includes template & CSS refactoring, bean & field-component improvements, & Ajax improvements.
See KRAD 2.2 Requirement details, at https://wiki.kuali.org/display/KULRICE/Framework+Code+Improvements+-+Template%2C+and+CSS+refactoring%2C+Field-Component+Improvements%2C+Ajax+Improvements |
1) Styles should be defined in the theme "branches", not in the bean/class' parent/base "root" that then applies across all themes. KRAD support for themes (and supply of at least 2 that applications can choose from/inherit) is important, demonstrating how easy it is for applications and institutions to customize through KRAD.
For example, in 2.2, the KNS L&F has inherited various font and other visual treatments from the KS L&F specs, whereas in 2.0, these were at the theme level (respecting the KNS L&F choices). These should be corrected to use the KNS L&F or the KS L&F, as appropriate, depending on the selected theme. 2) Both themes should use px for margins and padding, but not for fonts (use ems or % for fonts). There are several elements that have been changed in 2.2 to use px for fonts. These should be corrected (for example, in all headings for both themes). 3) Both themes should include a fall-back list of font families for every element (there should be no element that lists only one font family. For example, list "Helvetica, Arial, sans-serif" or "Times New Roman, Georgia, serif" instead of "Helvetica" or "Times New Roman". Without a fall-back list, there can be problems with font size inheritance when people use some methods to enlarge font sizing. See attachment for example where we have only one font defined for H2s in the portal, whereas all the other UI text elements include a fall-back list. |
Priority | Critical [ 2 ] | Major [ 3 ] |
Assignee | Brian Smith [ bsmith ] | Tom Clark [ thrclark ] |
Attachment | KNS L&F in 2.0 vs 2.2 M1 - example1.pdf [ 57436 ] | |
Component/s | Code Standards [ 13582 ] |
Fix Version/s | 2.2.0-m3 [ 16464 ] | |
Fix Version/s | 2.2.0-m2 [ 16463 ] |
Start Date | ||
Fix Date | 2012-07-23 [ set to sprint end date ] |
Reporter | Candace Soderston [ csoders ] | William Washington [ wwashington ] |
Fix Version/s | 2.2.0-m4 [ 16598 ] | |
Fix Version/s | 2.2.0-m3 [ 16464 ] |
Start Date | ||
Fix Date | 2012-07-23 | 2012-08-13 [ set to sprint end date ] |
Fix Version/s | 2.2-backlog [ 16475 ] | |
Fix Version/s | 2.2 [ 16411 ] | |
Fix Version/s | 2.2.0-m4 [ 16598 ] |
Fix Version/s | 2.2 [ 16411 ] | |
Affects Version/s | 2.2.0-m4 [ 16598 ] |
Fix Version/s | 2.2.1 [ 16733 ] | |
Fix Version/s | 2.2 [ 16411 ] | |
Fix Version/s | 2.2-backlog [ 16475 ] |
Fix Version/s | 2.3-backlog [ 16596 ] | |
Fix Version/s | 2.2.1 [ 16733 ] |
Workflow | custom [ 145509 ] | Copy of custom for rice [ 207416 ] |
Workflow | Copy of custom for rice [ 207416 ] | custom [ 217164 ] |
Workflow | custom [ 217164 ] | Rice Workflow [ 226912 ] |
Fix Version/s | 2.4 [ 16913 ] | |
Fix Version/s | 2.4-backlog [ 16596 ] |
Epic Link | KULRICE-10289 [ 121500 ] |
Fix Version/s | Backlog [ 15811 ] | |
Fix Version/s | 2.4 [ 16913 ] |
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Status | Resolved [ 5 ] | Closed [ 6 ] |
Fix Version/s | Not version specific [ 17967 ] | |
Fix Version/s | Backlog [ 15811 ] |
moving non-blocker and non-critical m4 Jiras to 2.2-backlog