Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-m2, 2.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7179Cleanup issues from Tooltip code review
      KULRICE-8363Review comments from RDV code review
      KULRICE-1811Code cleanup
      KULRICE-10110Cleanup on copy methods
      KULRICE-6608Misc. KRMS Code cleanup
      KULRICE-5373Issues from lightbox code review
      KULRICE-11659Additive Database Structure: Testing and code cleanup
      KULRICE-6298Remaining Issues from lightbox code review
      KULRICE-8775xapool cleanup errors
      KULRICE-9976KRAD-Data Code review updates
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Review notes from Master/Detail code review and make necessary modifications. Here is link to the review in Fisheye and notes from Jeff:

      http://fisheye.kuali.org/cru/rice-145

      Jerry - Need to have ability to specify image for link

      Currently checking whether table is supported using if statement - Is there a better option?

      • You could add a property to the layout manager that specifies whether it is supported
      • You could add another method to the interface

      There is an issue both Brian and Dan faced regarding adding items where extending a generic - Is there a better solution?

      Jerry - Please throw the UIF strings into KRAD variables

      Brian - Currently we are pre-generating all of details content. Could do an enhancement to support AJAX calls for content as needed?

      Jerry - Can we control the width of the details link column?

        Issue Links

          Activity

          Hide
          Jerry Neal (Inactive) added a comment -

          Also stumbled across this yesterday:

          TableLayoutManager seems to have properties that are not used?

          private String rowDetailsLinkName = "Details";
          private Image rowDetailsOpenImage;
          private Image rowDetailsCloseImage;

          There is no code referencing these.

          And the getter/setter for rowDetailsGroup needs javadocs:

          public Group getRowDetailsGroup()

          { return rowDetailsGroup; }

          public void setRowDetailsGroup(Group rowDetailsGroup)

          { this.rowDetailsGroup = rowDetailsGroup; }

          Thanks!

          Show
          Jerry Neal (Inactive) added a comment - Also stumbled across this yesterday: TableLayoutManager seems to have properties that are not used? private String rowDetailsLinkName = "Details"; private Image rowDetailsOpenImage; private Image rowDetailsCloseImage; There is no code referencing these. And the getter/setter for rowDetailsGroup needs javadocs: public Group getRowDetailsGroup() { return rowDetailsGroup; } public void setRowDetailsGroup(Group rowDetailsGroup) { this.rowDetailsGroup = rowDetailsGroup; } Thanks!
          Hide
          Brian Smith (Inactive) added a comment -

          Oops these are leftovers for when I was I going to put it in the TableLayoutManager (which I may still change it to if time permits), they should have been deleted

          Show
          Brian Smith (Inactive) added a comment - Oops these are leftovers for when I was I going to put it in the TableLayoutManager (which I may still change it to if time permits), they should have been deleted

            People

            • Assignee:
              Brian Smith (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel