Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-7617

The Super User Actions tag does not deal with action requests that are role requests

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.1
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-13234Super User Name does not appear for Requested Of
      KULRICE-1161Mouseover Approve button in Super User Action on Action Requests section does not change appearance of cursor
      KULRICE-7137Bug on Action List - Action Requested Label Blank after super user approve action
      KULRICE-7840Validation doesn't appear to be done correctly when completing a doc via the Super User Action tab
      KULRICE-13015Create necessary tests for Super User tab
      KULRICE-1744Implement proper Super User support in EDocLite
      KULRICE-14288Workflow routing does not travel child request hierarchy when generating action requests
      KULRICE-762Allow for execution of Super User functions on a document that is SAVED or INITIATED
      KULRICE-8300problems with implementation of super user tab
      KULRICE-6591delegated action request does not show up in Outbox
    • Rice Module:
      KEW
    • Application Requirement:
      KC
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The superUserActions.tag file does not take into account action requests that are role requests, this causes the tag file to blow up when the recipientType on the actionRequest is "R". If you notice the lines 31 - 39 in the tag file, you see that it handles the cases where the actionRequest is of type "U" (Principal) or type "W" (Group). However, when the recipientType of the action request is "R", this code defaults to line 36 which tries to get the groupId and since that is null for a role type recipient, the tag file blows up. In the ActionRequest.java class, I see that there is a method to check if a request is a RoleRequest (isRoleRequest) but it is never used. Ideally, this should be called and the tag file modified to accomodate this recipient type. There should be a statement in the tag file that looks something like this

      <c:when test="$

      {actionRequest.roleRequest}

      ">
      <c:out value="$

      {kfunc:getKimRoleDisplayName(actionRequest.roleId)}

      "/>
      </when>

        Activity

        Hide
        Peter Giles (Inactive) added a comment -

        Took a hack at a fix. Unfortunately, the role data on an ActionRequest is not as straightforward as you might imagine. I may have to tweak it, but let me know how it works for KC.

        Show
        Peter Giles (Inactive) added a comment - Took a hack at a fix. Unfortunately, the role data on an ActionRequest is not as straightforward as you might imagine. I may have to tweak it, but let me know how it works for KC.
        Hide
        Peter Giles (Inactive) added a comment -

        Resolving, please re-open if it doesn't do the trick.

        Show
        Peter Giles (Inactive) added a comment - Resolving, please re-open if it doesn't do the trick.
        Hide
        Jessica Coltrin (Inactive) added a comment -

        release notes are generated. closing issues.

        Show
        Jessica Coltrin (Inactive) added a comment - release notes are generated. closing issues.

          People

          • Assignee:
            Peter Giles (Inactive)
            Reporter:
            Gayathri Athreya
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel