Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-7636

Remove requirement that baseDocumentClass is a superclass of the documentClass

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-11468Add ability to remove mappings from superclass with JPA
      KULRICE-5721Remove requirement to specify EVENT in agenda selection criteria
      KULRICE-10866Modify the KradEclipseLinkCustomizer so that the @PortableSequenceGenerator annotation can be placed on a superclass field
      KULRICE-7058Required field getting removed on collection refresh
      KULRICE-11560Remove manually-detected duplicate code from SendNotificationMessageController and SendEventNotificationMessageController
      KULRICE-7778Required message pops up on field and not removed
      KULRICE-1152Remove the javascript requirement from JSP pages
      KULRICE-851Remove the javascript requirement from JSP pages
      KULRICE-11784Rework DataTablesPagingHelper to use lifecycle to remove form storage requirements
      KULRICE-11456Maintenance Conversion Script - M71 - M76, M79, M81 Carry overs
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Data Dictionary
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Please remove the portion of completeValidation() on DocumentEntry which checks that the baseDocumentClass is a superclass of the documentClass property.

      From what I can see, there is nothing in the Rice code which really cares about this so the restriction seems arbitrary.

      As part of implementations, sometimes the existing document hierarchy does not meet the institutions needs but the base document class needs to remain linked to the original hierarchy to preserve other baseline functionality. So, in some cases, the actual document class may not be a subclass of the original document, but may be a subclass of the original document's superclass. With this restriction in place, the server can not start up.

        Activity

        Hide
        Jessica Coltrin (Inactive) added a comment -

        setting to 2.1.2 for DM review

        Show
        Jessica Coltrin (Inactive) added a comment - setting to 2.1.2 for DM review
        Hide
        Aaron Hamid (Inactive) added a comment -

        Should we validate that there is a common superclass, or can they be completely unrelated?

        There are a few tests confirming this behavior.

        I noticed:

         /**
          * The optional baseDocumentClass element is the name of the java superclass
          * associated with the document. This gives the data dictionary the ability
          * to index by the superclass in addition to the current class.
          */
        

        but can't tell yet whether the relationship between the classes is actually relevant.

        It looks like BusinessObjectEntry has a similar check.

        Show
        Aaron Hamid (Inactive) added a comment - Should we validate that there is a common superclass, or can they be completely unrelated? There are a few tests confirming this behavior. I noticed: /** * The optional baseDocumentClass element is the name of the java superclass * associated with the document. This gives the data dictionary the ability * to index by the superclass in addition to the current class. */ but can't tell yet whether the relationship between the classes is actually relevant. It looks like BusinessObjectEntry has a similar check.
        Hide
        Jonathan Keller added a comment -

        I checked the KFS and Rice code before filing this. As far as I can tell, that indexing is the only reason that the baseDocumentClass is used. No code was making the assumption that it could cast one into the other. At UCD, I have removed that validation (Rice 1.0.3.1) with no ill effects.

        Show
        Jonathan Keller added a comment - I checked the KFS and Rice code before filing this. As far as I can tell, that indexing is the only reason that the baseDocumentClass is used. No code was making the assumption that it could cast one into the other. At UCD, I have removed that validation (Rice 1.0.3.1) with no ill effects.
        Hide
        Aaron Hamid (Inactive) added a comment -

        this has been fixed for both DocumentEntry and BusinessObjectEntry. tests have been added to confirm the doc/bo class does not need to be subclass of the base class.

        Show
        Aaron Hamid (Inactive) added a comment - this has been fixed for both DocumentEntry and BusinessObjectEntry. tests have been added to confirm the doc/bo class does not need to be subclass of the base class.

          People

          • Assignee:
            Aaron Hamid (Inactive)
            Reporter:
            Jonathan Keller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel