Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-7637

show inactive / hide inactive button on subtab is not working correctly.

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      Rice Core
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The "show inactive" and "hide inactive" button on the subtab in rowDisplay.tag (line 246) is not working correctly. Show inactive does not show the record. The linked KFSMI jira will provide more details. Here is the developer comments on kfsmi jira:

      The problem is on line 246, where it uses kul:subtab with the setting open="$

      {!rowHidden}

      . When this parameter is set to false, the asset location is not displayed at all regardless if the row is hidden or not. If I change this parameter to open="true", the show/hide inactive works as exactly as expected. I can confirm that the code for show/hiding the rows based on the row's active setting is correct. I'm thinking this is a rice issue since the tag file is a rice file.

      To test this: KFS Main Menu / Lookup and Maintenance - click on Asset and enter asset number: 320077 and click on Edit link. On the maintenance document, open the tab Components. There should be two records, one active and one inactive.

        Attachments

          Issue Links

            Activity

            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            closing all 2.1.2 Jiras

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - closing all 2.1.2 Jiras
            Hide
            ahamid Aaron Hamid (Inactive) added a comment -

            went back to drawing board and reverted the original coupling between hide/show inactive and tab state, which circumvents this "reopening" issue entirely. hiding and showing inactive rows works, with the stipulation that this action does not affect the open/close state of tabs.

            Show
            ahamid Aaron Hamid (Inactive) added a comment - went back to drawing board and reverted the original coupling between hide/show inactive and tab state, which circumvents this "reopening" issue entirely. hiding and showing inactive rows works, with the stipulation that this action does not affect the open/close state of tabs.
            Hide
            ahamid Aaron Hamid (Inactive) added a comment -

            Committed fix to decouple "hide/show inactive" with tab state. Hopefully that's the nail in the coffin for this particular issue. Functional requirements re: "hide/show inactive" and "hide/show" tab can continue to be refined on https://jira.kuali.org/browse/KFSMI-607

            Show
            ahamid Aaron Hamid (Inactive) added a comment - Committed fix to decouple "hide/show inactive" with tab state. Hopefully that's the nail in the coffin for this particular issue. Functional requirements re: "hide/show inactive" and "hide/show" tab can continue to be refined on https://jira.kuali.org/browse/KFSMI-607
            Hide
            ahamid Aaron Hamid (Inactive) added a comment - - edited

            Decoupling tab state from row visibility resolves this issue and is probably the more correct thing to do; KFSMI-5222 appears unaffected hide/show inactive works fine. Emailed Kymber for her opinion on this fix.

            Show
            ahamid Aaron Hamid (Inactive) added a comment - - edited Decoupling tab state from row visibility resolves this issue and is probably the more correct thing to do; KFSMI-5222 appears unaffected hide/show inactive works fine. Emailed Kymber for her opinion on this fix.
            Hide
            ahamid Aaron Hamid (Inactive) added a comment - - edited

            Muddu you are right, there is another NPE here. The underlying issue in this and previous case is that it's operating on a KNS Field object which has null property values. The fix for this NPE will be committed in a moment.

            I can reproduce this in a local KFS and am trying to get to the bottom of why the field/container information is not present (specifically containerElementName). Tab state is set to open on tab key generated from field/container name (this requires summaryTitle to be set in DD), however the tabs in question have tab keys generated by index so this doesn't actually work.

            subtab.tag

             <c:set var="tabKey" value="${currentTabIndex}"/>
            
            Show
            ahamid Aaron Hamid (Inactive) added a comment - - edited Muddu you are right, there is another NPE here. The underlying issue in this and previous case is that it's operating on a KNS Field object which has null property values. The fix for this NPE will be committed in a moment. I can reproduce this in a local KFS and am trying to get to the bottom of why the field/container information is not present (specifically containerElementName). Tab state is set to open on tab key generated from field/container name (this requires summaryTitle to be set in DD), however the tabs in question have tab keys generated by index so this doesn't actually work. subtab.tag <c:set var= "tabKey" value= "${currentTabIndex}" />

              People

              • Assignee:
                ahamid Aaron Hamid (Inactive)
                Reporter:
                mksalem Muddu Salem
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 6 hours
                  6h
                  Remaining:
                  Time Spent - 4 hours, 30 minutes Remaining Estimate - 1 hour, 30 minutes
                  1h 30m
                  Logged:
                  Time Spent - 4 hours, 30 minutes Remaining Estimate - 1 hour, 30 minutes
                  4h 30m