Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-7661

AdHoc Group request - isAddHocRouteWorkgroupValid() method should validate the groups permission and it is not.

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Duplicate
    • Affects Version/s: 2.1.1, 2.1.2
    • Fix Version/s: 2.1.1, 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      Rice Core
    • KRAD Feature Area:
      Document
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The stack trace is occurring because Sandy's group was not caught in the validation before it was submitted. When routing the workflow rejects the submission due to the invalid group and throws an error. For validating a group for Ad Hoc review, there is a rice method being called, org.kuali.rice.krad.rules.DocumentRuleBase.isAddHocRouteWorkgroupValid() which is returning true. It should be finding the group is invalid and returning false. This code does not check at all if the group indeed has permission to receive ad hoc reviews for PO docs. The result is the group is allowed and no nice error message appears informing the user the group is invalid. For Ad Hoc PERSON requests, there is a similar routine, isAddHocRoutePersonValid(), which in fact does check if the person has permission. Submission of persons for Ad hoc Review works properly because of this. I'm thinking this AdHoc Group request issue is a RICE issue where isAddHocRouteWorkgroupValid() should validate the groups permission just as isAddHocRoutePersonValid() does.

        Attachments

          Issue Links

            Activity

            Hide
            mksalem Muddu Salem added a comment -

            Apologies. Already same issue is reported in KULRICE-6938 so I am resolving this issue.

            Show
            mksalem Muddu Salem added a comment - Apologies. Already same issue is reported in KULRICE-6938 so I am resolving this issue.

              People

              • Assignee:
                Unassigned
                Reporter:
                mksalem Muddu Salem
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: