Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-7661

AdHoc Group request - isAddHocRouteWorkgroupValid() method should validate the groups permission and it is not.


    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Duplicate
    • Affects Version/s: 2.1.1, 2.1.2
    • Fix Version/s: 2.1.1, 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Similar issues:
      KULRICE-6938Adhoc Group Request results in stack trace
      KULRICE-7712Validate adhoc reviewers when clicking add
      KULRICE-5153Implement AdHoc Recipients tag for documents
      KULRICE-3936PersonDocumentGroupRule.validAssignGroup using wrong namespace when validating group assignments
      KULRICE-7339Adhoc routing for completion - client side validation
      KULRICE-8760CONTRIB: Multiple complete adhoc requests should not be allowed on the same document
      KULRICE-6439Check permissions for adhoc routing and action request types
      KULRICE-3577WorkflowUtilityWebServiceImpl.getPrincipalIdsInRouteLog does not return principal ids for group members who have action requests "on the route log"
      KULRICE-10652PeopleFlow members of type Group should not be able to set the action request policy
      KULRICE-1272On the Workgroup create/edit page when a lookup is used to find a user/group for the AdHoc Route section the Workgroup Entry page does not function
    • Rice Module:
      Rice Core
    • KRAD Feature Area:
    • Application Requirement:
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required


      The stack trace is occurring because Sandy's group was not caught in the validation before it was submitted. When routing the workflow rejects the submission due to the invalid group and throws an error. For validating a group for Ad Hoc review, there is a rice method being called, org.kuali.rice.krad.rules.DocumentRuleBase.isAddHocRouteWorkgroupValid() which is returning true. It should be finding the group is invalid and returning false. This code does not check at all if the group indeed has permission to receive ad hoc reviews for PO docs. The result is the group is allowed and no nice error message appears informing the user the group is invalid. For Ad Hoc PERSON requests, there is a similar routine, isAddHocRoutePersonValid(), which in fact does check if the person has permission. Submission of persons for Ad hoc Review works properly because of this. I'm thinking this AdHoc Group request issue is a RICE issue where isAddHocRouteWorkgroupValid() should validate the groups permission just as isAddHocRoutePersonValid() does.

        Issue Links


          Muddu Salem added a comment -

          Apologies. Already same issue is reported in KULRICE-6938 so I am resolving this issue.

          Muddu Salem added a comment - Apologies. Already same issue is reported in KULRICE-6938 so I am resolving this issue.


            • Assignee:
              Muddu Salem
            • Votes:
              0 Vote for this issue
              0 Start watching this issue


              • Created:

                Structure Helper Panel