Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-7666

Implement default existence checks for Maintenance document and support general data objects

          Details

          • Type: Task
          • Status: Closed
          • Priority: Blocker
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 2.4
          • Component/s: Development, KNS Equivalency, Roadmap
          • Security Level: Public (Public: Anyone can view)
          • Labels:
            None
          • Epic Link:
          • Rice Module:
            KRAD
          • KRAD Feature Area:
            Maintenance
          • Sprint:
            2.4.0-m4 KRAD Sprint 2
          • KAI Review Status:
            Not Required
          • KTI Review Status:
            Not Required
          • Include in Release Notes?:
            Yes

            Description

            Currently default existence checks are not being ran for KRAD maintenance documents. This is due to the restriction that the object be a business object. We need to allow for general data object support and enable in KRAD

            • Review MaintenanceDocumentRuleBase:processAddCollectionLine

              Attachments

                Issue Links

                cloned from

                Bug Fix - A problem which impairs or prevents the functions of the product. KULRICE-7208 Template

                • Major - Major loss of function.
                • Closed
                fixes

                Bug Fix - A problem which impairs or prevents the functions of the product. KULRICE-10492 IT Failure CountyMaintenanceDocumentTest BusinessObjectDaoProxy called with non-legacy class: CountryBo

                • Critical - Crashes, loss of data, severe memory leak.
                • Closed
                is relied upon by

                Task - A task that needs to be done. KULRICE-11488 M94 demo

                • Major - Major loss of function.
                • Closed
                relates to

                Rice Enhancement - An item to be included in a roadmap KRRM-144 KRAD Equivalency with KNS

                • Major - Major loss of function.
                • Open
                relies on

                Bug Fix - A problem which impairs or prevents the functions of the product. KULRICE-10655 Maintenance Business Rules missing processAddCollectionLineBusinessRules implementation

                • Major - Major loss of function.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  kbtaylor Kristina Taylor (Inactive) added a comment -

                  I think the hook that I added in MaintenanceDocumentRuleBase.processAddCollectionLine may also be an additional place where this is needed. If, however, the checks are working for both the base maintenance document and all of its collections, then please remove the commented hook.

                  Show
                  kbtaylor Kristina Taylor (Inactive) added a comment - I think the hook that I added in MaintenanceDocumentRuleBase.processAddCollectionLine may also be an additional place where this is needed. If, however, the checks are working for both the base maintenance document and all of its collections, then please remove the commented hook.
                  Hide
                  Permalink
                  kbtaylor Kristina Taylor (Inactive) added a comment - - edited

                  Does this mean that methods in DictionaryValidationService such as validateDefaultExistenceChecks(BusinessObject bo) should change to validateDefaultExistenceChecks(Object bo) or do the old methods need to be deprecated and new ones created?

                  Show
                  kbtaylor Kristina Taylor (Inactive) added a comment - - edited Does this mean that methods in DictionaryValidationService such as validateDefaultExistenceChecks(BusinessObject bo) should change to validateDefaultExistenceChecks(Object bo) or do the old methods need to be deprecated and new ones created?
                  Hide
                  Permalink
                  mztaylor Martin Taylor (Inactive) added a comment -

                  Ran through the DictionaryValidationService(Impl) and reset all method signatures from BusinessObject to Object to allow for dataObjects. When running tests found several needed to go through the KradLegacyDataAdapterImpl for testing reference definitions for collections and references. The methods (getReferenceIfExists, allForeignKeyValuesPopulatedForReference) being used were not implemented and produced exceptions. Began process of implementing methods and adding tests for business object and data objects.

                  Show
                  mztaylor Martin Taylor (Inactive) added a comment - Ran through the DictionaryValidationService(Impl) and reset all method signatures from BusinessObject to Object to allow for dataObjects. When running tests found several needed to go through the KradLegacyDataAdapterImpl for testing reference definitions for collections and references. The methods (getReferenceIfExists, allForeignKeyValuesPopulatedForReference) being used were not implemented and produced exceptions. Began process of implementing methods and adding tests for business object and data objects.
                  Hide
                  Permalink
                  mztaylor Martin Taylor (Inactive) added a comment -

                  Patch update KRADDataAdapterImpl for reference and foreign key checks, replaces BusinessObject reference with Object in DictionaryValidationService and LegacyDataAdapter and their implementations

                  Show
                  mztaylor Martin Taylor (Inactive) added a comment - Patch update KRADDataAdapterImpl for reference and foreign key checks, replaces BusinessObject reference with Object in DictionaryValidationService and LegacyDataAdapter and their implementations

                    People

                    • Assignee:
                      mztaylor Martin Taylor (Inactive)
                      Reporter:
                      jkneal Jerry Neal (Inactive)
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      4 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Time Tracking

                        Estimated:
                        Original Estimate - 3 days
                        3d
                        Remaining:
                        Time Spent - 1 day Remaining Estimate - 2 days
                        2d
                        Logged:
                        Time Spent - 1 day Remaining Estimate - 2 days
                        1d