Details
-
Type:
Task
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.4
-
Component/s: Development, KNS Equivalency, Roadmap
-
Security Level: Public (Public: Anyone can view)
-
Labels:None
-
Epic Link:
-
Rice Module:KRAD
-
KRAD Feature Area:Maintenance
-
Sprint:2.4.0-m4 KRAD Sprint 2
-
KAI Review Status:Not Required
-
KTI Review Status:Not Required
-
Include in Release Notes?:Yes
Description
Currently default existence checks are not being ran for KRAD maintenance documents. This is due to the restriction that the object be a business object. We need to allow for general data object support and enable in KRAD
- Review MaintenanceDocumentRuleBase:processAddCollectionLine
Attachments
Issue Links
- cloned from
-
KULRICE-7208 Template
-
- Closed
-
- fixes
-
-
- Closed
-
- is relied upon by
-
-
- Closed
-
- relates to
-
KRRM-144 KRAD Equivalency with KNS
-
- Open
-
- relies on
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue cloned from |
| KRAD Feature Area | [Maintenance] | |
| Description | Currently default existence checks are not being ran for KRAD maintenance documents. This is due to the restriction that the object be a business object. We need to allow for general data object support and enable in KRAD | |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Priority | Critical [ 2 ] | Major [ 3 ] |
| Component/s | KNS Equivalency [ 13684 ] |
| Fix Version/s | 2.2.1 [ 16733 ] | |
| Fix Version/s | 2.2 [ 16411 ] | |
| Fix Version/s | 2.2-backlog [ 16475 ] |
| Fix Version/s | 2.3-backlog [ 16596 ] | |
| Fix Version/s | 2.2.1 [ 16733 ] |
| Rice Lead | cniesen |
| Component/s | Roadmap [ 13903 ] |
| Fix Version/s | 2.3 [ 16595 ] | |
| Fix Version/s | 2.3.0-m2 [ 16757 ] | |
| Fix Version/s | 2.3-backlog [ 16596 ] |
| Include in Release Notes? | Yes [ 14658 ] |
| Fix Version/s | 2.4.0-m2 [ 17036 ] | |
| Fix Version/s | 2.4 [ 16913 ] | |
| Fix Version/s | 2.3 [ 16595 ] | |
| Fix Version/s | 2.3.0-m2 [ 16757 ] |
| Epic Link |
|
| Workflow | custom [ 149114 ] | Copy of custom for rice [ 207454 ] |
| Workflow | Copy of custom for rice [ 207454 ] | custom [ 217202 ] |
| Workflow | custom [ 217202 ] | Rice Workflow [ 226950 ] |
| Fix Version/s | 2.4.0-m2 [ 17036 ] |
| Link |
This issue is relied upon by |
| Comment |
[ {code}
Caused by: java.lang.ClassCastException: edu.sampleu.travel.dataobject.TravelerDetail cannot be cast to org.kuali.rice.krad.bo.BusinessObject at org.kuali.rice.krad.rules.MaintenanceDocumentRuleBase.dataDictionaryValidate(MaintenanceDocumentRuleBase.java:672) at org.kuali.rice.krad.rules.MaintenanceDocumentRuleBase.processGlobalSaveDocumentBusinessRules(MaintenanceDocumentRuleBase.java:857) at org.kuali.rice.krad.rules.MaintenanceDocumentRuleBase.processRouteDocument(MaintenanceDocumentRuleBase.java:173) at org.kuali.rice.krad.rules.rule.event.RouteDocumentEvent.invokeRuleMethod(RouteDocumentEvent.java:62) at org.kuali.rice.krad.service.impl.KualiRuleServiceImpl.applyRules(KualiRuleServiceImpl.java:85) at org.kuali.rice.krad.maintenance.MaintenanceDocumentBase.validateBusinessRules(MaintenanceDocumentBase.java:872) at org.kuali.rice.krad.service.impl.DocumentServiceImpl.validateAndPersistDocument(DocumentServiceImpl.java:842) at org.kuali.rice.krad.service.impl.DocumentServiceImpl.routeDocument(DocumentServiceImpl.java:189) at org.kuali.rice.krad.web.controller.DocumentControllerBase.performWorkflowAction(DocumentControllerBase.java:400) ... 75 more {code} ] |
| Sprint | 2.4.0-m4 KRAD Sprint 2 [ 171 ] |
| Priority | Major [ 3 ] | Blocker [ 1 ] |
| Original Estimate | 3 days [ 86400 ] |
| Remaining Estimate | 3 days [ 86400 ] |
| Link |
This issue relies on |
Does this mean that methods in DictionaryValidationService such as validateDefaultExistenceChecks(BusinessObject bo) should change to validateDefaultExistenceChecks(Object bo) or do the old methods need to be deprecated and new ones created?
| Assignee | Martin Taylor [ mztaylor ] |
| Description | Currently default existence checks are not being ran for KRAD maintenance documents. This is due to the restriction that the object be a business object. We need to allow for general data object support and enable in KRAD |
Currently default existence checks are not being ran for KRAD maintenance documents. This is due to the restriction that the object be a business object. We need to allow for general data object support and enable in KRAD
- Review MaintenanceDocumentRuleBase:processAddCollectionLine |
Ran through the DictionaryValidationService(Impl) and reset all method signatures from BusinessObject to Object to allow for dataObjects. When running tests found several needed to go through the KradLegacyDataAdapterImpl for testing reference definitions for collections and references. The methods (getReferenceIfExists, allForeignKeyValuesPopulatedForReference) being used were not implemented and produced exceptions. Began process of implementing methods and adding tests for business object and data objects.
| Remaining Estimate | 3 days [ 86400 ] | 2 days [ 57600 ] |
| Time Spent | 1 day [ 28800 ] | |
| Worklog Id | 91984 [ 91984 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
Patch update KRADDataAdapterImpl for reference and foreign key checks, replaces BusinessObject reference with Object in DictionaryValidationService and LegacyDataAdapter and their implementations
| Attachment | KULRICE-7666_1.patch [ 77156 ] |
| Link |
This issue fixes |
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
I think the hook that I added in MaintenanceDocumentRuleBase.processAddCollectionLine may also be an additional place where this is needed. If, however, the checks are working for both the base maintenance document and all of its collections, then please remove the commented hook.