Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-7666

Implement default existence checks for Maintenance document and support general data objects

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-9482Default Maintenance Document View from krad-data metadata
      KULRICE-13943When editing or copying objects supported by the data object service, primary key type conversion is not performed
      KULRICE-5067Implement backend support for general-purpose criteria query api
      KULRICE-10667Implement maintenance global documents on KRAD
      KULRICE-9505Implement proper support for serialization of maintenance document data in the krad-data framework
      KULRICE-4736Support for dynamic business objects
      KULRICE-4642Remove support for object remoting
      KULRICE-4158default existence checks do not work for collections
      KULRICE-5153Implement AdHoc Recipients tag for documents
      KULRICE-1667Fully implement the Namespace maintenance document
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Maintenance
    • Sprint:
      2.4.0-m4 KRAD Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Currently default existence checks are not being ran for KRAD maintenance documents. This is due to the restriction that the object be a business object. We need to allow for general data object support and enable in KRAD

      • Review MaintenanceDocumentRuleBase:processAddCollectionLine

        Issue Links

          Activity

          Hide
          Kristina Taylor (Inactive) added a comment -

          I think the hook that I added in MaintenanceDocumentRuleBase.processAddCollectionLine may also be an additional place where this is needed. If, however, the checks are working for both the base maintenance document and all of its collections, then please remove the commented hook.

          Show
          Kristina Taylor (Inactive) added a comment - I think the hook that I added in MaintenanceDocumentRuleBase.processAddCollectionLine may also be an additional place where this is needed. If, however, the checks are working for both the base maintenance document and all of its collections, then please remove the commented hook.
          Hide
          Kristina Taylor (Inactive) added a comment - - edited

          Does this mean that methods in DictionaryValidationService such as validateDefaultExistenceChecks(BusinessObject bo) should change to validateDefaultExistenceChecks(Object bo) or do the old methods need to be deprecated and new ones created?

          Show
          Kristina Taylor (Inactive) added a comment - - edited Does this mean that methods in DictionaryValidationService such as validateDefaultExistenceChecks(BusinessObject bo) should change to validateDefaultExistenceChecks(Object bo) or do the old methods need to be deprecated and new ones created?
          Hide
          Martin Taylor (Inactive) added a comment -

          Ran through the DictionaryValidationService(Impl) and reset all method signatures from BusinessObject to Object to allow for dataObjects. When running tests found several needed to go through the KradLegacyDataAdapterImpl for testing reference definitions for collections and references. The methods (getReferenceIfExists, allForeignKeyValuesPopulatedForReference) being used were not implemented and produced exceptions. Began process of implementing methods and adding tests for business object and data objects.

          Show
          Martin Taylor (Inactive) added a comment - Ran through the DictionaryValidationService(Impl) and reset all method signatures from BusinessObject to Object to allow for dataObjects. When running tests found several needed to go through the KradLegacyDataAdapterImpl for testing reference definitions for collections and references. The methods (getReferenceIfExists, allForeignKeyValuesPopulatedForReference) being used were not implemented and produced exceptions. Began process of implementing methods and adding tests for business object and data objects.
          Hide
          Martin Taylor (Inactive) added a comment -

          Patch update KRADDataAdapterImpl for reference and foreign key checks, replaces BusinessObject reference with Object in DictionaryValidationService and LegacyDataAdapter and their implementations

          Show
          Martin Taylor (Inactive) added a comment - Patch update KRADDataAdapterImpl for reference and foreign key checks, replaces BusinessObject reference with Object in DictionaryValidationService and LegacyDataAdapter and their implementations

            People

            • Assignee:
              Martin Taylor (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3 days
                3d
                Remaining:
                Time Spent - 1 day Remaining Estimate - 2 days
                2d
                Logged:
                Time Spent - 1 day Remaining Estimate - 2 days
                1d

                  Agile

                    Structure Helper Panel