Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-7777

Qualifier resolvers on KIM documents were not updated for Rice 2.0 classes

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7792DB Update: Qualifier resolvers on KIM documents were not updated for Rice 2.0 classes
      KULRICE-7793DB Update: DataDictionaryQualifierResolver class package was not updated in Rice 2.0 upgrade scripts
      KULRICE-7781DataDictionaryQualifierResolver class package was not updated in Rice 2.0 upgrade scripts
      KULRICE-1132Update KIM class diagram
      KULRICE-1705Rename all DefaultTestData files to use Module acronym to resolve classpath issues
      KULRICE-9892Enhance PeopleFlowTypeService and PeopleFlowRequestGeneratorImpl to allow resolving/accepting multiple maps of role qualifiers
      KULRICE-6038Update KSB documentation for changes made to KSB in 2.0
      KULRICE-7263Passing Collections.emptyMap() as role qualifier causes failures in KIM
      KULRICE-8648Update maintenance document XML update converters
      KULRICE-9165Person document not displaying role qualifiers
    • Rice Module:
      KIM
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The special qualifier resolver used on the group, Role, and Person documents is no longer correct in the delivered workflow XML. They still reference the org.kuali.rice.kim.workflow.attribute.KimTypeQualifierResolver class which has since been changed to org.kuali.rice.kim.impl.type.KimTypeQualifierResolver.

      This has broken the KFS org-based routing for these documents in KFS 5.0.

      I will be fixing this in the KFS upgrade scripts. But, this needs to be fixed in the master data source for new implementors.

        Issue Links

          Activity

          Hide
          Jonathan Keller added a comment -

          Additionally, look at the code in the attached image from the org.kuali.rice.kim.impl.type.KimTypeQualifierResolver class.

          It should be returning the custom document type name as is done in the handleRoleDocument() method just below it. I don't know what was going on here, but this change disabled the ability to have custom group document routing.

          Show
          Jonathan Keller added a comment - Additionally, look at the code in the attached image from the org.kuali.rice.kim.impl.type.KimTypeQualifierResolver class. It should be returning the custom document type name as is done in the handleRoleDocument() method just below it. I don't know what was going on here, but this change disabled the ability to have custom group document routing.
          Hide
          Jonathan Keller added a comment -

          FWIW, I used this to fix the data locally:

          UPDATE KREW_RTE_NODE_CFG_PARM_T
              SET VAL = REPLACE( VAL, 'org.kuali.rice.kim.workflow.attribute.KimTypeQualifierResolver', 'org.kuali.rice.kim.impl.type.KimTypeQualifierResolver' )
              WHERE val LIKE '%KimTypeQualifierResolver%'
          
          Show
          Jonathan Keller added a comment - FWIW, I used this to fix the data locally: UPDATE KREW_RTE_NODE_CFG_PARM_T SET VAL = REPLACE( VAL, 'org.kuali.rice.kim.workflow.attribute.KimTypeQualifierResolver', 'org.kuali.rice.kim.impl.type.KimTypeQualifierResolver' ) WHERE val LIKE '%KimTypeQualifierResolver%'
          Hide
          Peter Giles (Inactive) added a comment -

          Since we can't fix the data issue in 2.1.x, perhaps we can add a deprecated class with the old package and name.

          Show
          Peter Giles (Inactive) added a comment - Since we can't fix the data issue in 2.1.x, perhaps we can add a deprecated class with the old package and name.
          Hide
          Jonathan Keller added a comment -

          OK, that will work as well. But I also need that issue from the Qualifier resolver class fixed. So, if you need to wait for 2.2 to make the data fix, could you open a separate JIRA for that? Thanks.

          Show
          Jonathan Keller added a comment - OK, that will work as well. But I also need that issue from the Qualifier resolver class fixed. So, if you need to wait for 2.2 to make the data fix, could you open a separate JIRA for that? Thanks.
          Hide
          Peter Giles (Inactive) added a comment -

          Reduced to Critical based on KFS prioritization

          Show
          Peter Giles (Inactive) added a comment - Reduced to Critical based on KFS prioritization
          Hide
          Jonathan Keller added a comment -

          Actually - the KFSMI jira was miscategorized. Barb had changed it to a testing blocker (our internal flag) but not upped the JIRA priority flag. I had been reporting these as blockers based on our other flag.

          Show
          Jonathan Keller added a comment - Actually - the KFSMI jira was miscategorized. Barb had changed it to a testing blocker (our internal flag) but not upped the JIRA priority flag. I had been reporting these as blockers based on our other flag.
          Hide
          Peter Giles (Inactive) added a comment -

          No worries. I got a list of the top 25 jiras from Muddu, and it looks weird to have Blockers below Criticals, so I reduced the blockers below those top issues. Hopefully that's OK. I'm not sure what a Blocker means any more when it is below a Critical

          Show
          Peter Giles (Inactive) added a comment - No worries. I got a list of the top 25 jiras from Muddu, and it looks weird to have Blockers below Criticals, so I reduced the blockers below those top issues. Hopefully that's OK. I'm not sure what a Blocker means any more when it is below a Critical
          Hide
          Martin Taylor (Inactive) added a comment -

          Reinserted deprecated package/class as a subclass of the new package/class; Had issue testing and used RoleRouteModuleTest to confirm fix was working (did not commit test case bc of issue testing old/new package class).

          Show
          Martin Taylor (Inactive) added a comment - Reinserted deprecated package/class as a subclass of the new package/class; Had issue testing and used RoleRouteModuleTest to confirm fix was working (did not commit test case bc of issue testing old/new package class).
          Hide
          Martin Taylor (Inactive) added a comment -

          deprecated class/package reinserted as subclass of new class

          Show
          Martin Taylor (Inactive) added a comment - deprecated class/package reinserted as subclass of new class

            People

            • Assignee:
              Martin Taylor (Inactive)
              Reporter:
              Jonathan Keller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days
                2d

                  Structure Helper Panel