Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-m4, 2.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-1811Code cleanup
      KULRICE-6608Misc. KRMS Code cleanup
      KULRICE-6840UIF Framework - Framework Improvements (Template Cleanup)
      KULRICE-7474CLONE - UIF Framework - Framework Improvements (Template Cleanup)
      KULRICE-7581Cleanup from Master/Detail Code Review
      KULRICE-10052Cleanup parseExpression method
      KULRICE-11659Additive Database Structure: Testing and code cleanup
      KULRICE-8775xapool cleanup errors
      KULRICE-13250Ajax Retrieval Library Example: IndexOutOfBoundsException
      KULRICE-7179Cleanup issues from Tooltip code review
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Remaining cleanup items:

      • Need AjaxReturnType on Action component and pass through on actionHandler
      • Remove renderFullView, not needed since we can look at the returnType
      • Rename handleIncidentReport to checkForIncidentReport and cleanup code
      • Remove old ajax code not needed anymore (like updatePageCallback)
      • retrieveComponent has duplicate code with updateComponentHandler
      • Make sure optional parameters are at end of ajax methods and documented as optional on the param tag
      • Redo navigation action links so they don't call handleActionLink but use the standard ajax submit (passing navigateToPageId as submitdata)
      • add constants in krad.variables.js for return types (like "update-page")

      In UifDocumentDefinitions.xml, see if we can change:

      <bean parent="Uif-PrimaryActionButton-Small" p:methodToCall="downloadAttachment"
      p:actionLabel="download attachment" p:title="download attachment"
      p:onClickScript="writeHiddenToForm("skipViewInit", "true");writeHiddenToForm("renderFullView", "false");writeHiddenToForm("unblockUIOnLoading", "true");writeHiddenToForm("actionParameters[selectedLineIndex]", "@

      {#index}

      ");"/>

      to use dataAttributes for the hiddens (besides the one actionParameters which can write the property directly)

      p:dataAttributes="skipViewInit:true, ..."

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Jerry Neal (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel