Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-8048

People Flow - Adding roles to a stop allowed without selecting the role

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-12523People Flow: Group and Role Member not displayed on confirmation & DocSearch views
      KULRICE-12555Rebuild People Flow
      KULRICE-14064People Flow does not add an annotation in Route Log
      KULRICE-9962Add a description field to People Flow stops that would appear in the route log or even the action list
      KULRICE-9892Enhance PeopleFlowTypeService and PeopleFlowRequestGeneratorImpl to allow resolving/accepting multiple maps of role qualifiers
      KULRICE-9081Stack trace while doing wilcard searches in role lookup while adding role member delegate
      KULRICE-7619People Flow members of type Role appear as type Principal when editing
      KULRICE-9959Member Lookup missing from People Flow Maintenance screen
      KULRICE-7972People Flow: No routing option for and/or in the same stop.
      KULRICE-12694People Flow: Principal, Group and Role add causes exception
    • Rice Module:
      KRMS
    • Application Requirement:
      KC
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      System allows a stop to be added to peopleflow with member type = role, without the role being selected. See attached image.
      Steps to recreate:
      1. Create a people flow document with minimum fields required. To the first stop, add a member delegate with member type "Role" and add the row.

      The system lets you do this though no member has been specified. I am also able to save the document with no member selected. However, when I try to delete the row, I get the following stack trace.

      java.lang.RuntimeException: Exception evaluating expression: !view.readOnly at org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl.evaluateExpression(ExpressionEvaluatorServiceImpl.java:118) at org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl.evaluatePropertyExpressions(ExpressionEvaluatorServiceImpl.java:220) at org.kuali.rice.krad.uif.service.impl.ExpressionEvaluatorServiceImpl.evaluateObjectExpressions(ExpressionEvaluatorServiceImpl.java:59) at org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl.performComponentApplyModel(ViewHelperServiceImpl.java:664) at org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl.performComponentApplyModel(ViewHelperServiceImpl.java:715) at org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl.performComponentApplyModel(ViewHelperServiceImpl.java:715) at org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl.performComponentLifecycle(ViewHelperServiceImpl.java:251) at org.kuali.rice.krad.web.controller.UifControllerBase.updateComponent(UifControllerBase.java:441) at org.kuali.rice.krad.web.controller.UifControllerBase.deleteLine(UifControllerBase.java:217) at org.kuali.rice.krad.web.controller.UifControllerBase$$FastClassByCGLIB$$7929303a.invoke(<generated>) at net.sf.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) at org.springframework.aop.framework.Cglib2AopProxy$CglibMethodInvocation.invokeJoinpoint(Cglib2AopProxy.java:689) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:110) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:90) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.Cglib2AopProxy$DynamicAdvisedInterceptor.intercept(Cglib2AopProxy.java:622) at org.kuali.rice.kew.impl.peopleflow.PeopleFlowController$$EnhancerByCGLIB$$62196cac.deleteLine(<generated>) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.web.bind.annotation.support.HandlerMethodInvoker.invokeHandlerMethod(HandlerMethodInvoker.java:176) at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:436) at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:424) at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:900) at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:827) at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882) at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:789) at javax.servlet.http.HttpServlet.service(HttpServlet.java:641) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.catalina.core.ApplicationFilterChain.internalDoFil

      I also noticed that when I try to add a member with member type principal, it lets me add it but errors when I try to save. This does not happen when the member type is Role.

        Activity

        Hide
        Gayathri Athreya added a comment -

        Downgrading from blocker status and moving to 2.1.3.

        Show
        Gayathri Athreya added a comment - Downgrading from blocker status and moving to 2.1.3.
        Hide
        Jessica Coltrin (Inactive) added a comment -

        moving back to 2.1.2 since it's not an ad hoc routing issue.

        Show
        Jessica Coltrin (Inactive) added a comment - moving back to 2.1.2 since it's not an ad hoc routing issue.
        Hide
        Sona Sona (Inactive) added a comment -

        There is a validation issue which is fixed in 2.2 and may become available after the merge. Other then that the above exception has been fixed and the validation for the member name has also been added.

        Show
        Sona Sona (Inactive) added a comment - There is a validation issue which is fixed in 2.2 and may become available after the merge. Other then that the above exception has been fixed and the validation for the member name has also been added.
        Hide
        Jessica Coltrin (Inactive) added a comment -

        closing all 2.1.2 Jiras

        Show
        Jessica Coltrin (Inactive) added a comment - closing all 2.1.2 Jiras

          People

          • Assignee:
            Sona Sona (Inactive)
            Reporter:
            Gayathri Athreya
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel