Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-8074

Getting client side validation errors when no errors are present

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.2.0-m4, 2.2
    • Component/s: Quality Assurance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Team:
      QA
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      In a few different places (like people flow edit and adding note attachments), we are getting a client side validation error that says 'validation.null'. The fields are valid as well and there is no way past the error. See screenshots

        Attachments

          Issue Links

            Activity

            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Brian,

            Please make this issue your priority.

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Brian, Please make this issue your priority. thanks, Jerry
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Brian,

            Did you determine this was fixed yesterday? If so please resolve.

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Brian, Did you determine this was fixed yesterday? If so please resolve. thanks, Jerry
            Hide
            bsmith Brian Smith (Inactive) added a comment - - edited

            It exists AFTER the update, so something between my last update and my newest update is what broke it. It did not exist locally before I updated.

            Show
            bsmith Brian Smith (Inactive) added a comment - - edited It exists AFTER the update, so something between my last update and my newest update is what broke it. It did not exist locally before I updated.
            Hide
            bsmith Brian Smith (Inactive) added a comment -

            I tracked down the issue to a method that was added in validationPattern which converts patterns into constraints and makes some false assumptions:

            ValidCharactersConstraint constraint = new ConfigurationBasedRegexPatternConstraint();
            constraint.setValue(this.getRegexPattern().pattern());
            return constraint;

            1. some pattern regex does not have a javascript equivalent - this is what causes the error to appear - it fails the regex check obviously
            2. no labelKey and validationMessageParams are set so all messaging is lost - thus you are seeing "validation.null"

            Not sure what to do here and what the intent of this method was to begin with. Is it intended to be a stop gap or a permanent solution (if its supposed to be a permanent solution it has serious problems noted above).

            Show
            bsmith Brian Smith (Inactive) added a comment - I tracked down the issue to a method that was added in validationPattern which converts patterns into constraints and makes some false assumptions: ValidCharactersConstraint constraint = new ConfigurationBasedRegexPatternConstraint(); constraint.setValue(this.getRegexPattern().pattern()); return constraint; 1. some pattern regex does not have a javascript equivalent - this is what causes the error to appear - it fails the regex check obviously 2. no labelKey and validationMessageParams are set so all messaging is lost - thus you are seeing "validation.null" Not sure what to do here and what the intent of this method was to begin with. Is it intended to be a stop gap or a permanent solution (if its supposed to be a permanent solution it has serious problems noted above).
            Hide
            jkneal Jerry Neal (Inactive) added a comment -

            Brian,

            Can you determine who made the update and reach out them for more information?

            thanks,
            Jerry

            Show
            jkneal Jerry Neal (Inactive) added a comment - Brian, Can you determine who made the update and reach out them for more information? thanks, Jerry
            Hide
            bsmith Brian Smith (Inactive) added a comment -

            This will be fixed after Martin does a rollback of the code and Peter merges with trunk.

            Show
            bsmith Brian Smith (Inactive) added a comment - This will be fixed after Martin does a rollback of the code and Peter merges with trunk.
            Hide
            gilesp Peter Giles (Inactive) added a comment -

            Is the fix version on this correct? Can this issue be resolved now that Martin's rollback has been applied to trunk?

            Show
            gilesp Peter Giles (Inactive) added a comment - Is the fix version on this correct? Can this issue be resolved now that Martin's rollback has been applied to trunk?
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            closing all 2.1.2 Jiras

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - closing all 2.1.2 Jiras

              People

              • Assignee:
                bsmith Brian Smith (Inactive)
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: