Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-8074

Getting client side validation errors when no errors are present

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.2.0-m4, 2.2
    • Component/s: Quality Assurance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-7026Alter behavior of client side validation
      KULRICE-11109Server-side Validation Error on valid dates
      KULRICE-7312Client-side validation tooltip doesn't open (for timed interval) when other validation treatment is applied
      KULRICE-6661Client side validation errors not getting removed when value changed with a date picker
      KULRICE-7772Client side validation no longer properly notifies the user with a popup nor jumps them back to the page error list
      KULRICE-6835Issues with client side validation
      KULRICE-4708Support for client side field validation
      KULRICE-11729Selectively disable client side validation on KRAD collections
      KULRICE-7889Client-side summaries on save feature lost
    • Rice Team:
      QA
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      In a few different places (like people flow edit and adding note attachments), we are getting a client side validation error that says 'validation.null'. The fields are valid as well and there is no way past the error. See screenshots

        Issue Links

          Activity

          Jerry Neal (Inactive) made changes -
          Field Original Value New Value
          Link This issue cloned from KULRICE-7208 [ KULRICE-7208 ]
          Hide
          Jerry Neal (Inactive) added a comment -

          Brian,

          Please make this issue your priority.

          thanks,
          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Brian, Please make this issue your priority. thanks, Jerry
          Jerry Neal (Inactive) made changes -
          Issue Type Task [ 3 ] Bug Fix [ 1 ]
          Fix Version/s 2.2.0-m4 [ 16598 ]
          Fix Version/s 2.2-backlog [ 16475 ]
          Description In a few different places (like people flow edit and adding note attachments), we are getting a client side validation error that says 'validation.null'. The fields are valid as well and there is no way past the error. See screenshots
          Priority Major [ 3 ] Blocker [ 1 ]
          Assignee Brian Smith [ bsmith ]
          Jerry Neal (Inactive) made changes -
          Attachment screenshot-1.jpg [ 61155 ]
          Hide
          Jerry Neal (Inactive) added a comment -

          Brian,

          Did you determine this was fixed yesterday? If so please resolve.

          thanks,
          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Brian, Did you determine this was fixed yesterday? If so please resolve. thanks, Jerry
          Hide
          Brian Smith (Inactive) added a comment - - edited

          It exists AFTER the update, so something between my last update and my newest update is what broke it. It did not exist locally before I updated.

          Show
          Brian Smith (Inactive) added a comment - - edited It exists AFTER the update, so something between my last update and my newest update is what broke it. It did not exist locally before I updated.
          Hide
          Brian Smith (Inactive) added a comment -

          I tracked down the issue to a method that was added in validationPattern which converts patterns into constraints and makes some false assumptions:

          ValidCharactersConstraint constraint = new ConfigurationBasedRegexPatternConstraint();
          constraint.setValue(this.getRegexPattern().pattern());
          return constraint;

          1. some pattern regex does not have a javascript equivalent - this is what causes the error to appear - it fails the regex check obviously
          2. no labelKey and validationMessageParams are set so all messaging is lost - thus you are seeing "validation.null"

          Not sure what to do here and what the intent of this method was to begin with. Is it intended to be a stop gap or a permanent solution (if its supposed to be a permanent solution it has serious problems noted above).

          Show
          Brian Smith (Inactive) added a comment - I tracked down the issue to a method that was added in validationPattern which converts patterns into constraints and makes some false assumptions: ValidCharactersConstraint constraint = new ConfigurationBasedRegexPatternConstraint(); constraint.setValue(this.getRegexPattern().pattern()); return constraint; 1. some pattern regex does not have a javascript equivalent - this is what causes the error to appear - it fails the regex check obviously 2. no labelKey and validationMessageParams are set so all messaging is lost - thus you are seeing "validation.null" Not sure what to do here and what the intent of this method was to begin with. Is it intended to be a stop gap or a permanent solution (if its supposed to be a permanent solution it has serious problems noted above).
          Hide
          Jerry Neal (Inactive) added a comment -

          Brian,

          Can you determine who made the update and reach out them for more information?

          thanks,
          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Brian, Can you determine who made the update and reach out them for more information? thanks, Jerry
          Hide
          Brian Smith (Inactive) added a comment -

          This will be fixed after Martin does a rollback of the code and Peter merges with trunk.

          Show
          Brian Smith (Inactive) added a comment - This will be fixed after Martin does a rollback of the code and Peter merges with trunk.
          Brian Smith (Inactive) made changes -
          Link This issue fixes KULRICE-8038 [ KULRICE-8038 ]
          Erik Meade made changes -
          Fix Version/s 2.1.2 [ 16590 ]
          Fix Version/s QA-backlog [ 16610 ]
          Fix Version/s 2.2 [ 16411 ]
          Fix Version/s 2.2.0-m4 [ 16598 ]
          Affects Version/s 2.1.1 [ 16554 ]
          Erik Meade made changes -
          Rank Ranked higher
          Erik Meade made changes -
          Link This issue is relied upon by KULRICE-8066 [ KULRICE-8066 ]
          Hide
          Peter Giles (Inactive) added a comment -

          Is the fix version on this correct? Can this issue be resolved now that Martin's rollback has been applied to trunk?

          Show
          Peter Giles (Inactive) added a comment - Is the fix version on this correct? Can this issue be resolved now that Martin's rollback has been applied to trunk?
          Brian Smith (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Brian Smith (Inactive) made changes -
          Fix Version/s 2.2.0-m4 [ 16598 ]
          Hide
          Jessica Coltrin (Inactive) added a comment -

          closing all 2.1.2 Jiras

          Show
          Jessica Coltrin (Inactive) added a comment - closing all 2.1.2 Jiras
          Jessica Coltrin (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 152947 ] Copy of custom for rice [ 214882 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 214882 ] custom [ 224630 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 224630 ] Rice Workflow [ 234378 ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s Backlog [ 15811 ]
          Fix Version/s 2.1.2 [ 16590 ]
          Fix Version/s QA-backlog [ 16610 ]
          Component/s Quality Assurance [ 11245 ]
          Component/s Development [ 11244 ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s Backlog [ 15811 ]
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s 2.2 [ 16411 ]
          Adam Campbell (Inactive) made changes -
          Rice Team QA [ 16025 ]

            People

            • Assignee:
              Brian Smith (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel