Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-8219

Services in KIM referencing KRAD dictionary validation service

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5947Add validation for data dictionary defined custom attributes
      KULRICE-4666Evaluate "remote" KIM services
      KULRICE-5439Dictionary Validation Service does not handle lists of primitives
      KULRICE-7706KRAD role type services passing nulls to location/core service methods
      KULRICE-2355KIM Identity Service Test
      KULRICE-2356KIM Authentication Service Test
      KULRICE-2269Write Unit Tests for KIM Services
      KULRICE-1118Develop KIM Identity Service base service methods
      KULRICE-6664Validation ServerSide for KRAD Views
      KULRICE-2394KIM Responsibility Service Test
    • Rice Module:
      KNS
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Performed a review of dictionary validation service usage with Jonathan and found there are two references from KIM (still running in the KNS) that are using the KRAD dictionary validation service. These need to be changed to use the KNS dictionary validation service:

      org.kuali.rice.kns.datadictionary.validation.AttributeValidatingTypeServiceBase
      org.kuali.rice.kns.kim.type.DataDictionaryTypeServiceBase

      The goal is to not have any KNS code using the constraint logic of KRAD, so they should all be referencing the KNS dictionary validation service. After these two are cleaned up that separation will be achieved.

      Also, just one small cleanup item. KualiRuleServiceImpl has a dependency on DictionaryValidationService but is not actually using it. We should remove this to prevent confusion.

        Issue Links

          Activity

          Jerry Neal (Inactive) made changes -
          Field Original Value New Value
          Fix Version/s 2.1.2 [ 16590 ]
          Fix Version/s 2.1.3 [ 16606 ]
          Hide
          Peter Giles (Inactive) added a comment - - edited

          Hey Jerry, I've already Jira'd this one up I think (although you may have some additional work identified here too), see the linked issue. If you look at the Hierarchy for the KRAD DocumentRuleBase you'll see what I'm talking about. I had a brief thread with Jonathan about this where we had decided to change these over to the KNS DictionaryValidationService in 2.1.3 to give more time for testing w/ that change before the release (See this comment). Obviously, all the testing that KFS has done up to this point of KIM has been using the KRAD DictionaryValidationService. Do you feel that this is a low risk enough change to make pretty close to the release of 2.1.2?

          Show
          Peter Giles (Inactive) added a comment - - edited Hey Jerry, I've already Jira'd this one up I think (although you may have some additional work identified here too), see the linked issue. If you look at the Hierarchy for the KRAD DocumentRuleBase you'll see what I'm talking about. I had a brief thread with Jonathan about this where we had decided to change these over to the KNS DictionaryValidationService in 2.1.3 to give more time for testing w/ that change before the release (See this comment ). Obviously, all the testing that KFS has done up to this point of KIM has been using the KRAD DictionaryValidationService. Do you feel that this is a low risk enough change to make pretty close to the release of 2.1.2?
          Peter Giles (Inactive) made changes -
          Link This issue duplicates KULRICE-8124 [ KULRICE-8124 ]
          Hide
          Jerry Neal (Inactive) added a comment -

          Hi Peter,

          My feeling is the validation of KIM attributes is probably not working correctly, or I don't see how it could be. So I would think we want to get it switched over. But I'll leave it up to the KFS as far as the timing and whether or not they want the change for 2.1.2.

          Jerry

          Show
          Jerry Neal (Inactive) added a comment - Hi Peter, My feeling is the validation of KIM attributes is probably not working correctly, or I don't see how it could be. So I would think we want to get it switched over. But I'll leave it up to the KFS as far as the timing and whether or not they want the change for 2.1.2. Jerry
          Hide
          Jonathan Keller added a comment -

          I don't think we are experiencing any blocker issues regarding this for KFS 5.0. So, I would say to, yes, make the fix, but make it on the main 2.1 branch.

          Show
          Jonathan Keller added a comment - I don't think we are experiencing any blocker issues regarding this for KFS 5.0. So, I would say to, yes, make the fix, but make it on the main 2.1 branch.
          Peter Giles (Inactive) made changes -
          Link This issue duplicates KULRICE-8124 [ KULRICE-8124 ]
          Peter Giles (Inactive) made changes -
          Link This issue is related to KULRICE-8124 [ KULRICE-8124 ]
          Peter Giles (Inactive) made changes -
          Assignee Steve Manning [ sdm86 ]
          Ailish Byrne made changes -
          Application Requirement KFS [ 10874 ]
          Ailish Byrne made changes -
          Link This issue duplicates KFSMI-9493 [ KFSMI-9493 ]
          Steve Manning (Inactive) made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Rice Module KNS [ 10873 ]
          Resolution Fixed [ 1 ]
          Hide
          Steve Manning (Inactive) added a comment -

          Fix for KFS-5.0 spring-rice-krad-overrides.xml file

          Show
          Steve Manning (Inactive) added a comment - Fix for KFS-5 .0 spring-rice-krad-overrides.xml file
          Steve Manning (Inactive) made changes -
          Attachment KR-8219-KFS-patch.txt [ 61580 ]
          Hide
          Jessica Coltrin (Inactive) added a comment -

          closing all 2.1.2 Jiras

          Show
          Jessica Coltrin (Inactive) added a comment - closing all 2.1.2 Jiras
          Jessica Coltrin (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 153831 ] Copy of custom for rice [ 214974 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 214974 ] custom [ 224722 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 224722 ] Rice Workflow [ 234470 ]

            People

            • Assignee:
              Steve Manning (Inactive)
              Reporter:
              Jerry Neal (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel