Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-13077Investigate Implementing Super User Screen
      KULRICE-12866Implement Super User Functionality in KRAD
      KULRICE-1744Implement proper Super User support in EDocLite
      KULRICE-14165Super User Validations on Documents
      KULRICE-13015Create necessary tests for Super User tab
      KULRICE-7719Missing buttons on Super User Approval Tab
      KULRICE-7799Create a separate permission for accessing the new super user tab
      KULRICE-9146SuperUserAction tab does not load when using custom DocumentTypeAuthorizer implementation in embedded mode
      KULRICE-7840Validation doesn't appear to be done correctly when completing a doc via the Super User Action tab
      KULRICE-8252Permission check for super user tab seems to be using the wrong namespace
    • Rice Module:
      KNS
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      there seem to be a couple of fundamental problems with the way the super user tab enhancement was implemented.

      1. apparently due to the no db change for minor release rule, the specs were not followed in terms of the permission type service

      2. whoever implemented this didn't understand the the KR-WKFLW Administer Routing for document permission is checked in the bowels of Rice (specifically children of SuperUserActionTakenEvent) - this ommission defeats the whole point of the enhancement, requiring the users have access to the more powerful super user screen in order to use the more controlled super user tab.

      3. we're confused as to why the tab would show up with disapprove as an option for an initiated document - I checked testdrive, and cancel - not disapprove - shows up as an option for an initiated document on the workflow super user screen. since we didn't ask for cancel on the super user tab, i assume the tab wouldn't even show up for initiated documents - for saved it would because there is an action request to be completed (disapprove still not an option till enroute though). i hope we're not showing other illogical options like disapprove or approve when the doc is processed, final, cancelled.

      i will include our suggestions for resolution below

      1. B1_KR_LOAD_ALL_RuleTmpls.xml
        0.6 kB
        Shannon Hess
      2. C2_KR_LOAD_ALL_Normal_grps.xml
        0.5 kB
        Shannon Hess
      3. countryaxct.xml
        2 kB
        Shannon Hess
      4. G1_KR_LOAD_ALL_NORMAL_Rules.xml
        2 kB
        Shannon Hess
      5. KULRICE-8300-test-data.sql
        9 kB
        Bryan Hutchinson
      6. KULRICE-8300-test-data.sql
        9 kB
        Bryan Hutchinson
      7. mysql-2012-09-26-for kim type and perm templates.sql
        4 kB
        Bryan Hutchinson
      8. mysql-2012-09-26-for kim type and perm templates.sql
        4 kB
        Shannon Hess
      9. oracle-2012-09-26-for kim type and perm template.sql
        4 kB
        Shannon Hess
      1. ApproveAndDissaproveAvailableInSavedStatus.PNG
        154 kB
      2. ButtonsStillAvailableAfterDisapprove.PNG
        154 kB
      3. DisapproveWhenInSavedStatusIncidentReport.PNG
        178 kB
      4. InvalidSuperUserApproveAction.PNG
        170 kB
      5. InvalidSuperUserDisapproveAction.PNG
        178 kB

        Issue Links

          Activity

          Hide
          Shannon Hess added a comment -

          Bryan,

          Both of the issues you were seeing are fixed now.

          • I made it so the approve disapprove document buttons are not available when the document is in SAVED status. The approve document button isn't on the super user screen when the document is in SAVED status so I didn't think it should be on the super user tab either, even if it does work.
          • The second issue was a bit tricky. At times when the approve or disapprove document buttons are hit, the form loads and thinks the document is still ENROUTE, because it is processing behind the scenes. I made it so the document has to be reloaded if the approve or disapprove document buttons are hit and there are no active action requests at the time when the form loads.

          Can you please bring in the latest changes and verify all is working correctly now?

          Thanks for attaching that updated mysql SQL!

          Thanks,
          Shannon

          Show
          Shannon Hess added a comment - Bryan, Both of the issues you were seeing are fixed now. I made it so the approve disapprove document buttons are not available when the document is in SAVED status. The approve document button isn't on the super user screen when the document is in SAVED status so I didn't think it should be on the super user tab either, even if it does work. The second issue was a bit tricky. At times when the approve or disapprove document buttons are hit, the form loads and thinks the document is still ENROUTE, because it is processing behind the scenes. I made it so the document has to be reloaded if the approve or disapprove document buttons are hit and there are no active action requests at the time when the form loads. Can you please bring in the latest changes and verify all is working correctly now? Thanks for attaching that updated mysql SQL! Thanks, Shannon
          Hide
          Bryan Hutchinson added a comment -

          Shannon,

          Updated, and verified these issues are fixed with your latest changes.

          Thanks,
          Bryan

          Show
          Bryan Hutchinson added a comment - Shannon, Updated, and verified these issues are fixed with your latest changes. Thanks, Bryan
          Hide
          Shannon Hess added a comment -

          Created KULRICE-8370 to have the database changes applied to the master database. I'm going to resolve this JIRA since that was the last item that needed to be done.

          Show
          Shannon Hess added a comment - Created KULRICE-8370 to have the database changes applied to the master database. I'm going to resolve this JIRA since that was the last item that needed to be done.
          Hide
          Bryan Hutchinson added a comment -

          FWIW, I've uploaded an updated sql file with test data - I was using the KR-WKFLW nmspc_cd where I should have been using the KFS-SYS nmspc_cd. This doesn't affect the status of this JIRA as I corrected the data before implementing in KFS and things were fine. It's just an FYI and to close the loop on this detail I found in later testing.

          Show
          Bryan Hutchinson added a comment - FWIW, I've uploaded an updated sql file with test data - I was using the KR-WKFLW nmspc_cd where I should have been using the KFS-SYS nmspc_cd. This doesn't affect the status of this JIRA as I corrected the data before implementing in KFS and things were fine. It's just an FYI and to close the loop on this detail I found in later testing.
          Hide
          Jessica Coltrin (Inactive) added a comment -

          closing all 2.1.2 Jiras

          Show
          Jessica Coltrin (Inactive) added a comment - closing all 2.1.2 Jiras

            People

            • Assignee:
              Shannon Hess
              Reporter:
              Bryan Hutchinson
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel