Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-8353

Lookup controller does not check return of validation call

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0-m4, 2.2
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      LookupController.search() calls lookupable.validateSearchParameters() but it doesn't use the return value to determine performSearch(). Please add a check before calling performSearch() (It's in rice 2.2 M3)

      // validate search parameters
      lookupable.validateSearchParameters(lookupForm, lookupForm.getLookupCriteria());

      Collection<?> displayList = lookupable.performSearch(lookupForm, lookupForm.getLookupCriteria(), true);

        Attachments

          Issue Links

            Activity

            jkneal Jerry Neal (Inactive) created issue -
            jkneal Jerry Neal (Inactive) made changes -
            Field Original Value New Value
            Link This issue cloned from KULRICE-7208 [ KULRICE-7208 ]
            jkneal Jerry Neal (Inactive) made changes -
            Issue Type Task [ 3 ] Bug Fix [ 1 ]
            Fix Version/s 2.2.0-m4 [ 16598 ]
            Fix Version/s 2.2-backlog [ 16475 ]
            Reporter Jerry Neal [ jkneal ] Venkat PremChandran [ vpremcha ]
            Description  LookupController.search() calls lookupable.validateSearchParameters() but it doesn't use the return value to determine performSearch(). Please add a check before calling performSearch() (It's in rice 2.2 M3)

            // validate search parameters
                    lookupable.validateSearchParameters(lookupForm, lookupForm.getLookupCriteria());

                    Collection<?> displayList = lookupable.performSearch(lookupForm, lookupForm.getLookupCriteria(), true);
            Priority Major [ 3 ] Critical [ 2 ]
            Assignee Jerry Neal [ jkneal ]
            jkneal Jerry Neal (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jkneal Jerry Neal (Inactive) made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 154696 ] Copy of custom for rice [ 215068 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow Copy of custom for rice [ 215068 ] custom [ 224816 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 224816 ] Rice Workflow [ 234564 ]

              People

              • Assignee:
                jkneal Jerry Neal (Inactive)
                Reporter:
                vpremcha Venkat PremChandran (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: