Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-8542

Person, role & group docs should not allow multiple docs editing the same record to be saved at the same time

    Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 2.1.3
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-4575IM Person doc should only allow editing of direct group memberships
      KULRICE-4516KimDocumentRoleMemberLookupableHelperServiceImpl confused by multiple docs
      KULRICE-7178When editing a role, the app allows you to add the same user multiple times in the assignee section.
      KULRICE-8391Screen to edit multiple parameters at the same time
      KULRICE-4677Person/Group/Role/Permission/Responsibility update screen Save/Submit enhancements
      KULRICE-5924Rice Dev: Person and Group Maintenance documents not saving edits?
      KULRICE-5694Under some circumstances lookups can return the same row multiple times
      KULRICE-8760CONTRIB: Multiple complete adhoc requests should not be allowed on the same document
      KULRICE-1799Figure out how to handle the potential conflict of having two different documents saving to the same join (i.e. group membership)
      KULRICE-6858If editing groups or roles, it validates the existence of all members before saving the doc, even those which are "inactive"
    • Rice Module:
      KIM
    • Application Requirement:
      KFS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      KFS maintenance docs don't allow you to have more than one doc affecting a record saved our enroute. Rice docs should have the same locking mechanism in place. The person doc allows multiple docs to be in saved status affecting the same person.

        Issue Links

          Activity

          Jonathan Keller made changes -
          Field Original Value New Value
          Link This issue cloned from KFSMI-9656 [ KFSMI-9656 ]
          Jonathan Keller made changes -
          Link This issue is duplicated by KFSMI-9853 [ KFSMI-9853 ]
          Jonathan Keller made changes -
          Project KFS Development [ 10300 ] Kuali Rice Development [ 10220 ]
          Key KFSMI-9856 KULRICE-8542
          Workflow KFSMI [ 157731 ] custom [ 157732 ]
          Status Awaiting Prioritization [ 10018 ] Open [ 1 ]
          Contributing Partner Not Applicable [ 14189 ]
          Fix Version/s Release ? [ 13530 ]
          Security Public [ 10015 ]
          KTI Review Status Not Required [ 13053 ]
          KAI Review Status Not Required [ 13050 ]
          Requires Application Refactoring No [ 10923 ]
          IU Required Release & Priority Parent values: Implementation(12892). Level 1 values: Blocker(12895).
          Sub-Committee SYS [ 14170 ]
          Responsible Team Rice Team [ 10940 ]
          Reviewed by Prioritization Committee No [ 10443 ]
          QA Review Status Not Required [ 13668 ]
          Impacted Modules System [ 13725 ]
          Application Requirement KFS [ 10874 ]
          Rice Module KIM [ 11060 ]
          Component/s Development [ 11244 ]
          Replicated in Test Drive? Yes - Old Functionality / Old Bug [ 14337 ]
          Forced Change No [ 11114 ]
          Hide
          Jessica Coltrin (Inactive) added a comment -

          setting to 2.1.3 for DM review.

          Show
          Jessica Coltrin (Inactive) added a comment - setting to 2.1.3 for DM review.
          Jessica Coltrin (Inactive) made changes -
          Fix Version/s 2.1.3 [ 16606 ]
          Peter Giles (Inactive) made changes -
          Rank Ranked higher
          Peter Giles (Inactive) made changes -
          Assignee Claus Niesen [ cniesen ]
          Hide
          Claus Niesen added a comment -

          I think there are a few inconsistencies in regards to preventing a document be altered if a saved version exists.

          Following behavior has been observed:

          KRMS Agenda Editor - last submission overrides
            Edited agenda (changed name), save
            Edited agenda (changed campus), submit
            Open saved agenda, submit
            -> name change presisted, campus was reset to original
          
          KRMS Context - error
            Edited context (changed name), save
            Edited context (changed description), submit
            Open saved context, submit
            -> Error: This document cannot be Saved or Routed because a record with the same primary key already exists.
            
          People Flow - error
            Edited people flow (changed name), save
            Edited people flow (changed description), submit
            Open saved people flow, submit
            -> Error: This document cannot be Saved or Routed because a record with the same primary key already exists.
          
          Campus - error
            Edited campus (changed name), save
            Edited campus (changed short name), submit
            Open saved campus, submit
            -> Error: This document cannot be Saved or Routed because a record with the same primary key already exists.
          
          Person - last submission overrides
            Edited person (changed principal name), save
            Edited person (changed active indicator), blanket approve
            Open saved person, blanket approve
            -> principal name change presisted, active indicator reset to original
          
          Person - both affiliation added
            Added affiliation, save
            Added different affiliation, blanket approve
            Open saved person, blanket approve
            -> both affiliations are added
            
          Person - last submission overrides
            Change affiliation (A) to new affiliation (B), save
            Change affiliation (A) to new affiliation (C), blanket approve
            open saved person, blanket approve
            -> the affiliation (C) overrides (B)
          

          Do we have documentation how multiple separate document changes should be handled?

          Show
          Claus Niesen added a comment - I think there are a few inconsistencies in regards to preventing a document be altered if a saved version exists. Following behavior has been observed: KRMS Agenda Editor - last submission overrides Edited agenda (changed name), save Edited agenda (changed campus), submit Open saved agenda, submit -> name change presisted, campus was reset to original KRMS Context - error Edited context (changed name), save Edited context (changed description), submit Open saved context, submit -> Error: This document cannot be Saved or Routed because a record with the same primary key already exists. People Flow - error Edited people flow (changed name), save Edited people flow (changed description), submit Open saved people flow, submit -> Error: This document cannot be Saved or Routed because a record with the same primary key already exists. Campus - error Edited campus (changed name), save Edited campus (changed short name), submit Open saved campus, submit -> Error: This document cannot be Saved or Routed because a record with the same primary key already exists. Person - last submission overrides Edited person (changed principal name), save Edited person (changed active indicator), blanket approve Open saved person, blanket approve -> principal name change presisted, active indicator reset to original Person - both affiliation added Added affiliation, save Added different affiliation, blanket approve Open saved person, blanket approve -> both affiliations are added Person - last submission overrides Change affiliation (A) to new affiliation (B), save Change affiliation (A) to new affiliation (C), blanket approve open saved person, blanket approve -> the affiliation (C) overrides (B) Do we have documentation how multiple separate document changes should be handled?
          Claus Niesen made changes -
          Link This issue discovered KULRICE-8622 [ KULRICE-8622 ]
          Hide
          Claus Niesen added a comment -

          The KIM screens are transactional documents. KNS requires custom locking code to be added to transactional documents. Since we will be converting these screens to KRAD Maintenance documents soon (Rice 2.3) we will be addressing the locking issue then.

          Show
          Claus Niesen added a comment - The KIM screens are transactional documents. KNS requires custom locking code to be added to transactional documents. Since we will be converting these screens to KRAD Maintenance documents soon (Rice 2.3) we will be addressing the locking issue then.
          Claus Niesen made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          Barb Sutton made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 157732 ] Copy of custom for rice [ 215220 ]
          Shem Patterson (Inactive) made changes -
          Workflow Copy of custom for rice [ 215220 ] custom [ 224968 ]
          Shem Patterson (Inactive) made changes -
          Workflow custom [ 224968 ] Rice Workflow [ 234716 ]

            People

            • Assignee:
              Claus Niesen
              Reporter:
              Barb Sutton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Structure Helper Panel