Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-8711

Default value property of DataField should have type of Object

    Details

    • Type: Bug Fix
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      Currently the defaultValue property of DataField is type String. This prevents setting default values for properties other than string (like Date) through expressions. The type should be changed to Object

        Attachments

          Issue Links

            Activity

            Hide
            dsiebert Daniel Seibert (Inactive) added a comment -

            My 2 cents after looking attempting to set a defaultValue for a date:

            I see two quick, easy solutions:
            1. In ViewHelperServiceImpl.populateDefaultValueForField(). Check the dataField for a propertyEditor assigned. If so, use it. If not, use ObjectPropertReference.setPropertyValue() to handle the primitive type cases. (In this case, in the maintenance view definition, assigned p:propertyEditorClass="org.kuali.rice.krad.web.bind.UifDateEditor" )

            2. In ObjectPropertyReference.setPropertyValue(), add logic to handle dates with UifDateEditor in addition to the primitive types.

            Show
            dsiebert Daniel Seibert (Inactive) added a comment - My 2 cents after looking attempting to set a defaultValue for a date: I see two quick, easy solutions: 1. In ViewHelperServiceImpl.populateDefaultValueForField(). Check the dataField for a propertyEditor assigned. If so, use it. If not, use ObjectPropertReference.setPropertyValue() to handle the primitive type cases. (In this case, in the maintenance view definition, assigned p:propertyEditorClass="org.kuali.rice.krad.web.bind.UifDateEditor" ) 2. In ObjectPropertyReference.setPropertyValue(), add logic to handle dates with UifDateEditor in addition to the primitive types.
            Hide
            dsiebert Daniel Seibert (Inactive) added a comment -

            On changing type of defaultValue property from String to Object:
            1. some existing code is expecting a String using StringUtils to check for empty and notEmpty
            2. If using Spring EL to specify a date, you still need a String to Date conversion.

            Show
            dsiebert Daniel Seibert (Inactive) added a comment - On changing type of defaultValue property from String to Object: 1. some existing code is expecting a String using StringUtils to check for empty and notEmpty 2. If using Spring EL to specify a date, you still need a String to Date conversion.

              People

              • Assignee:
                dsiebert Daniel Seibert (Inactive)
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day
                  1d