Details

    • Type: Bug Fix Bug Fix
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-9853Uif-DialogGroup ignoring KeyLabelPair beans
      KULRICE-13151Add reset fields option to DialogGroup
      KULRICE-12592IT Failure No bean named Uif-DialogGroup is defined
      KULRICE-13930Create Demo for DialogGroup's destroy dialog on hidden
      KULRICE-13931Create AFT for DialogGroup's destroy dialog on hidden demo
      KULRICE-9801non-DialogGroup dialog from hidden section appears on submit
      KULRICE-12885CleanContextDeep naming problem and nesting problems
      KULRICE-3879Problems with Rice metadata
      KULRICE-13225Problems with lookup return and easyxdm
      KULRICE-4091Fix portlet iframe resizing problem
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      UIF Component
    • Application Requirement:
      KS, KPME
    • Sprint:
      2.4.0-m4 KRAD Sprint 1, 2.4.0-m4 KRAD Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      It isn't possible to get the answer from a dialog when the page is rendered in an iframe (only iframes allow you to place non-form content in a dialog). Method "hasDialogBeenAnswered" will return the correct response, but "getStringDialogResponse" always returns null.

      1. KULRICE-8801_fix.patch
        9 kB
        Claus Niesen
      2. KULRICE-8801_sample.patch
        2 kB
        Claus Niesen

        Issue Links

          Activity

          Hide
          William Washington (Inactive) added a comment -

          Bob Hurt I'd like to separate the issues reported here into distinct bugs. Can you clarify the following (which I removed from the description) so that I can file in a separate bug:

          "I also noticed that if I close the dialog using the "X" button in the top-right corner two or three times, the popup disappears but the html source for the dialog is then visible at the bottom of the page. And the dialog buttons are active; the page responds to clicking on the Yes/No button."

          Was this when you had the content rendered in an iframe?

          Show
          William Washington (Inactive) added a comment - Bob Hurt I'd like to separate the issues reported here into distinct bugs. Can you clarify the following (which I removed from the description) so that I can file in a separate bug: "I also noticed that if I close the dialog using the "X" button in the top-right corner two or three times, the popup disappears but the html source for the dialog is then visible at the bottom of the page. And the dialog buttons are active; the page responds to clicking on the Yes/No button." Was this when you had the content rendered in an iframe?
          Hide
          Bob Hurt (Inactive) added a comment -

          In reply to William's 27/Jun/13 4:01 PM question: unfortunately, at this point I don't recall if I was testing it in an iframe or not. I want to say no, but I honestly don't remember.

          Show
          Bob Hurt (Inactive) added a comment - In reply to William's 27/Jun/13 4:01 PM question: unfortunately, at this point I don't recall if I was testing it in an iframe or not. I want to say no, but I honestly don't remember.
          Show
          Venkat PremChandran (Inactive) added a comment - looks like it's working fine within iframe http://env2.ks.kuali.org/portal.do?channelTitle=Message%20Box&channelUrl=http://env2.ks.kuali.org/kr-krad/kitchensink?viewId=KS-KitchenSink-MessageBox-View&methodToCall=start
          Hide
          Neeraj Khanolkar added a comment -

          Claus Niesen and I could both not confirm Venkat's assertion above. In the example that he has linked to, clicking either 'yes' or 'no' shows the same warning "be more careful next time" indicating that the 'yes' answer has not been recorded, and its just the 'no' execution path being run over and over again.

          We are also seeing the issue in KPME in a maintenance screen where a simple yes-no dialog box always returns 'no' as the answer. Tracing the code through rice, we could see that the actual answer is recorded as 'null', which gets translated to 'false' via the org.kuali.rice.krad.uif.view.DialogManager.wasDialogAnswerAffirmative(String) method which in turn is called by the getBooleanDialogResponse() method.

          Furthermore, when we opened the same maintenance screen in a frame by itself (In firefox: This Frame -> Show only this frame), the issue goes away and the yes-no answers are recorded correctly and do change our execution paths as desired.

          This issue is a blocker for us since we plan to use yes/no dialog boxes in many places to ask for user confirmation to proceed for certain actions, so we request it be fast-tracked. (see KPME-2368) Thanks!

          Show
          Neeraj Khanolkar added a comment - Claus Niesen and I could both not confirm Venkat's assertion above. In the example that he has linked to, clicking either 'yes' or 'no' shows the same warning "be more careful next time" indicating that the 'yes' answer has not been recorded, and its just the 'no' execution path being run over and over again. We are also seeing the issue in KPME in a maintenance screen where a simple yes-no dialog box always returns 'no' as the answer. Tracing the code through rice, we could see that the actual answer is recorded as 'null', which gets translated to 'false' via the org.kuali.rice.krad.uif.view.DialogManager.wasDialogAnswerAffirmative(String) method which in turn is called by the getBooleanDialogResponse() method. Furthermore, when we opened the same maintenance screen in a frame by itself (In firefox: This Frame -> Show only this frame ), the issue goes away and the yes-no answers are recorded correctly and do change our execution paths as desired. This issue is a blocker for us since we plan to use yes/no dialog boxes in many places to ask for user confirmation to proceed for certain actions, so we request it be fast-tracked. (see KPME-2368 ) Thanks!
          Hide
          Jessica Coltrin (Inactive) added a comment -

          assigning to Claus since KPME needs it in 2.3.3.

          Show
          Jessica Coltrin (Inactive) added a comment - assigning to Claus since KPME needs it in 2.3.3.
          Hide
          Claus Niesen added a comment -

          This issue only exists in 2.3 branch when the portal is used. In 2.4 it's already fixed. The KULRICE-8801_fix.patch file contains the fixes that need to be applied to the 2.3 branch to make it work. KULRICE-8801_sample.patch can be used for testing (submit a KRMS Agenda).

          This code change does not need to be merged into trunk as the code exists already there.

          Show
          Claus Niesen added a comment - This issue only exists in 2.3 branch when the portal is used. In 2.4 it's already fixed. The KULRICE-8801 _fix.patch file contains the fixes that need to be applied to the 2.3 branch to make it work. KULRICE-8801 _sample.patch can be used for testing (submit a KRMS Agenda). This code change does not need to be merged into trunk as the code exists already there.
          Hide
          Neeraj Khanolkar added a comment -

          Thanks Claus! Just tested with rice 2.3.4 in KPME trunk and seems to work for us now.

          Show
          Neeraj Khanolkar added a comment - Thanks Claus! Just tested with rice 2.3.4 in KPME trunk and seems to work for us now.

            People

            • Assignee:
              Claus Niesen
              Reporter:
              Bob Hurt (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day
                1d
                Remaining:
                Remaining Estimate - 1 day
                1d
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Agile

                    Structure Helper Panel