Details

    • Similar issues:
      KULRICE-4358improved validation error messages.
      KULRICE-6623Context namespace is not validated on Agenda submit.
      KULRICE-6835Issues with client side validation
      KULRICE-9832Look at Bootstrap validation/error display
      KULRICE-5156Validate client side flag on view not being looked at for client side validation
      KULRICE-12203Elements - Action - Validation Message needs to describe validation is “required field”
      KULRICE-6680UI Framework - Data Dictionary Validation
      KULRICE-14207EmailAddressValidationPattern rejects valid email
      KULRICE-10983Reduce validation message divs
      KULRICE-13003Test git with mvn validate
    • Epic Link:
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Session
    • Application Requirement:
      KS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Brian S: we don't mark pages that have errors. we mark tabs, but not navigation tabs.

      If you're doing an Ajax submit, the page is sent to the server (the default). Only the fields on the page is validated b/c those are hte only ones that are rendered (in the DOM). If the view level is submitted, then the entire view is sent to the server.

      The client-side validation has the option validates the page, and then the controller has the option of doing a view validation. if there is a view validation error, a message can come back indicating that there is an error on the other page, but no indication of where it is, b/c those fields on the other page aren't renderd in the DOM. This error could arise when you leave a page that has a validation error, and then submit the view from another page.

      Navigating from page to page shows a dirty field indicator, but you can leave the page with invalid data, and data is not cleared (the data is still in the session). When a user navigates back to the page, no validation errors are shown, and the invalid data is still there.

      View Validation Service (a.k.a. server-side validation - useful to check that data sent from client is actually accurate, and not messed with via ajax; sort of a security check; also helps ensure that any required fields from other pages are saved.) - jira exists (submitted by Brian) to only validate the page so that you don't get errors on other pages.

      JIRA needed to address scenario when there are errors on other pages (if the controller called the view validation service before saving. currently no default on what the controller does (can save all view, just page, or part of page)). Brian believes Maintenance Docs just saves without doing a validation call.

      Current behavior when an "unmatched" field comes back it's something like "<propertyname>: required".

        Issue Links

          Activity

          Hide
          William Washington (Inactive) added a comment -

          Additional background:

          Garey Taylor: KS devs using “validation decorators” - these call the datadictonary method.

          • says we’re not calling validate.view method from w/in ENR.
          • we do validate the view, but it’s done manually.
            • form is “pulled apart” and individual parts of the form are validated.
              • e.g. only like terms can be rolled over.
            • validation service by default uses datadictionary validation.
            • “validation decorator” is only in KS, and that’s part of the service infrastructure.
              • includes datadictonary validation just before the it “hits the service layer”
              • some issues found when things that are valid in db aren’t valid for view.
              • Action: William to check with Bonnie/Venkat if there are errors found via the validation decorator, we are likely not able to give specific field-level error messages.
          • if the validateXYZ() method is called, it returns a list of failures on a field by field basis. If this method is skipped and the app goes directly to create/update, then a DataValidationException is thrown but might not have the detail
          • Haroon: perhaps Brian can give suggestion of where it’s improperly used.
          Show
          William Washington (Inactive) added a comment - Additional background: Garey Taylor: KS devs using “validation decorators” - these call the datadictonary method. says we’re not calling validate.view method from w/in ENR. we do validate the view, but it’s done manually. form is “pulled apart” and individual parts of the form are validated. e.g. only like terms can be rolled over. validation service by default uses datadictionary validation. “validation decorator” is only in KS, and that’s part of the service infrastructure. includes datadictonary validation just before the it “hits the service layer” some issues found when things that are valid in db aren’t valid for view. Action: William to check with Bonnie/Venkat if there are errors found via the validation decorator, we are likely not able to give specific field-level error messages. if the validateXYZ() method is called, it returns a list of failures on a field by field basis. If this method is skipped and the app goes directly to create/update, then a DataValidationException is thrown but might not have the detail Haroon: perhaps Brian can give suggestion of where it’s improperly used.
          Hide
          Garey Taylor added a comment -

          I think my comment was taken out of context. Ie. I was not talking about Cross-Page validation.

          Show
          Garey Taylor added a comment - I think my comment was taken out of context. Ie. I was not talking about Cross-Page validation.

            People

            • Assignee:
              Unassigned
              Reporter:
              William Washington (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 4 weeks
                4w
                Remaining:
                Remaining Estimate - 4 weeks
                4w
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Structure Helper Panel