Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-8956

ComponentBase performFinalize Performance Improvement

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3.1
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-5257Suggest Box - Improvements
      KULRICE-8448Improve Role Performance
      KULRICE-6735Document the Performance Improvements
      KULRICE-11177Need JPA related caching functionality to improve performance and support clustering
      KULRICE-14218Release 2.3.7 with KRMS performance improvements
      KULRICE-7029Remove refresh property on ComponentBase
      KULRICE-9313Perform experiment on cloning for performance improvements
      KULRICE-6557Improve Performance and Memory Consumption
      KULRICE-8918Improved KRAD collections performance
      KULRICE-12491Performance improvement for readXml in XmlHelper
    • Epic Link:
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      UIF Component
    • Sprint:
      2.3.1 Sprint 2
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      The performFinalize method in ComponentBase has some logic around like 277 related to tab indexes.
      getComponentsForLifecycle is called, which instantiates a bunch of new objects, and then internal to that for loop it determines whether or not the logic should be performed.

      By raising the check for skipInTabOrder to outside of the for loop, a simple check can be made of whether or not that logic needs to be performed at all.

      if(skipInTabOrder){
      for (Component component : getComponentsForLifecycle()) {
      if (component != null && component instanceof ComponentBase) {
      ((ComponentBase) component).setSkipInTabOrder(skipInTabOrder);
      if (component instanceof ControlBase)

      { ((ControlBase) component).setTabIndex(-1); }

      }
      }
      }

        Issue Links

          Activity

          Hide
          Jessica Coltrin (Inactive) added a comment -

          moving out of scope for 2.3 as we narrow down to what's critical for release.

          Show
          Jessica Coltrin (Inactive) added a comment - moving out of scope for 2.3 as we narrow down to what's critical for release.

            People

            • Assignee:
              Brian Smith (Inactive)
              Reporter:
              Jeff Domeyer (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Time Spent - 10 minutes Remaining Estimate - 20 minutes
                20m
                Logged:
                Time Spent - 10 minutes Remaining Estimate - 20 minutes
                10m

                  Agile

                    Structure Helper Panel