Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Code Standards
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      In WebDriverLegacyITBase.java, in gotoNestedFrame, there should be break lines around the two if statements.

        Attachments

          Activity

          Hide
          eghm-kuali-m Erik Meade added a comment -

          Not sure I understand like this?

              protected void gotoNestedFrame() {
                  driver.manage().timeouts().implicitlyWait(1, TimeUnit.SECONDS);
                  driver.switchTo().defaultContent();
          
                  if (driver.findElements(By.xpath("//iframe")).size() > 0) {
                      WebElement containerFrame = driver.findElement(By.xpath("//iframe"));
                      driver.switchTo().frame(containerFrame);
                  }
                  if (driver.findElements(By.xpath("//iframe")).size() > 0) {
                      WebElement contentFrame = driver.findElement(By.xpath("//iframe"));
                      driver.switchTo().frame(contentFrame);
                  }
          
                  driver.manage().timeouts().implicitlyWait(waitSeconds, TimeUnit.SECONDS);
              }
          
          Show
          eghm-kuali-m Erik Meade added a comment - Not sure I understand like this? protected void gotoNestedFrame() { driver.manage().timeouts().implicitlyWait(1, TimeUnit.SECONDS); driver.switchTo().defaultContent(); if (driver.findElements(By.xpath( " //iframe" )).size() > 0) { WebElement containerFrame = driver.findElement(By.xpath( " //iframe" )); driver.switchTo().frame(containerFrame); } if (driver.findElements(By.xpath( " //iframe" )).size() > 0) { WebElement contentFrame = driver.findElement(By.xpath( " //iframe" )); driver.switchTo().frame(contentFrame); } driver.manage().timeouts().implicitlyWait(waitSeconds, TimeUnit.SECONDS); }
          Hide
          eghm-kuali-m Erik Meade added a comment -

          Not sure I understand, please see above comment.

          Show
          eghm-kuali-m Erik Meade added a comment - Not sure I understand, please see above comment.
          Hide
          eghm-kuali-m Erik Meade added a comment -

          duplicate code has since been extracted

          Show
          eghm-kuali-m Erik Meade added a comment - duplicate code has since been extracted

            People

            • Assignee:
              eghm-kuali-m Erik Meade
              Reporter:
              matthew.wuertz Matthew Wuertz (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: