Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0-m1, 2.3
    • Component/s: Code Standards
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-9391Code Report
      KULRICE-11724Code Report
      KULRICE-12587Code Report
      KULRICE-10659Code Report
      KULRICE-11546Code Report
      KULRICE-9154Code Report
      KULRICE-10099Code Report
      KULRICE-8989Code Report
      KULRICE-8990Code Report
      KULRICE-9036Code Report
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      In ViewDictionaryServiceImpl.java, in getResultSetLimitForLookup, there is too much nesting. We don't want to go more than three levels deep at most. Please use helper methods or inverted conditionals to reduce nesting.

        Activity

        Hide
        Shannon Hess added a comment -

        I added a helper method in getResultSetLimitForLookup to correct this issue.

        Thanks,
        Shannon

        Show
        Shannon Hess added a comment - I added a helper method in getResultSetLimitForLookup to correct this issue. Thanks, Shannon

          People

          • Assignee:
            Shannon Hess
            Reporter:
            Matthew Wuertz (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel