Kuali Rice Development
  1. Kuali Rice Development
  2. KULRICE-9048 WebDriverLegacyITBase refactoring for Smoke tests
  3. KULRICE-9057

Replace duplicate code in Smoke test WebDriverLegacyITBase as detected by Intellij Analysis duplication with values over 23 (not counting assert blocks)

    Details

    • Type: Sub Task Sub Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.0-m1, 2.3
    • Component/s: Quality Assurance
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Similar issues:
      KULRICE-11560Remove manually-detected duplicate code from SendNotificationMessageController and SendEventNotificationMessageController
      KULRICE-8348Smoke Tests for validating duplicated named documents are not allowed.
      KULRICE-11491Remove duplicated test resources from KRAD web framework
      KULRICE-11060OAOO duplicate code in RuleBaseValuesLookupableHelperServiceImpl and RuleDelegationLookupableHelperServiceImpl
      KULRICE-11374OAOO duplicate code in SendNotificationMessageController submitSimpleNotificationMessage and SendEventNotificationMessageController submitEventNotificationMessage
      KULRICE-9367Update Smoke Test WebDriverLegacyITBase testValidCharsConstraintIT to use assertFocusTypeBlurValidation
      KULRICE-4634Removing some duplication in the code base
      KULRICE-12934Some classes are duplicated multiple times over if they are added during the lifecycle
      KULRICE-2189KSBHttpInvokerHandler is not tolerant of duplicate slashes
      KULRICE-5591Duplicate values indexed in KREW_DOC_HDR_EXT_*_T tables on occasion
    • Rice Team:
      QA
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required

      Description

      Within reason, Intellij -> Anaylize -> just WebDriverLegacyITBase for duplicates whose values are greater than 23, leaving all the check boxes unchecked. Note a few blocks of assertions with different values are indicated, those we don't want to change.

        Activity

        Hide
        Daniel Seibert (Inactive) added a comment -

        Reorganized code to avoid duplicates.
        Created methods for common code sections.

        Show
        Daniel Seibert (Inactive) added a comment - Reorganized code to avoid duplicates. Created methods for common code sections.

          People

          • Assignee:
            Daniel Seibert (Inactive)
            Reporter:
            Erik Meade
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Structure Helper Panel