Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-9230

KNS should not use the KRAD SessionDocumentService

          Details

          • Type: Task
          • Status: Closed
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: 2.1.4, 2.2.2
          • Fix Version/s: 2.2.3
          • Component/s: Development
          • Security Level: Public (Public: Anyone can view)
          • Labels:
            None
          • Rice Module:
            KNS
          • KAI Review Status:
            Not Required
          • KTI Review Status:
            Not Required
          • Include in Release Notes?:
            Yes

            Description

            The KRAD SessionDocumentService is referenced from org.kuali.rice.kns.web.struts.action.KualiDocumentActionBase.loadDocument(), the last line of which is

            KRADServiceLocatorWeb.getSessionDocumentService().addDocumentToUserSession(GlobalVariables.getUserSession(), workflowDoc);

              Attachments

                Issue Links

                relates to

                Task - A task that needs to be done. KULRICE-9149 Remove usage of org.kuali.rice.krad.service.impl.SessionDocumentServiceImpl in KRAD

                • Critical - Crashes, loss of data, severe memory leak.
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  gilesp Peter Giles (Inactive) added a comment -

                  Hey Corey, while you're at it please double check and make sure that the KRAD SessionDocumentService doesn't get called from anywhere else in the KNS. Thanks!

                  Show
                  gilesp Peter Giles (Inactive) added a comment - Hey Corey, while you're at it please double check and make sure that the KRAD SessionDocumentService doesn't get called from anywhere else in the KNS. Thanks!
                  Hide
                  Permalink
                  cpedersen Corey Pedersen (Inactive) added a comment -

                  I can not find any other usages in KNS of KRAD's SessionDocumentService.

                  Show
                  cpedersen Corey Pedersen (Inactive) added a comment - I can not find any other usages in KNS of KRAD's SessionDocumentService.
                  Hide
                  Permalink
                  cpedersen Corey Pedersen (Inactive) added a comment -

                  Committed revision 38069. For KNS (KualiDocumentActionBase) replace usage of KRADServiceLocatorWeb.getSessionDocumentService with KNSServiceLocator.getSessionDocumentService.

                  Show
                  cpedersen Corey Pedersen (Inactive) added a comment - Committed revision 38069. For KNS (KualiDocumentActionBase) replace usage of KRADServiceLocatorWeb.getSessionDocumentService with KNSServiceLocator.getSessionDocumentService.
                  Hide
                  Permalink
                  gilesp Peter Giles (Inactive) added a comment -

                  Hey Corey, looks like this went into trunk instead of rice-2.2. Hopefully I didn't tell you to do that (which I very well may have), but in any case, a reminder to keep an eye on the fix version

                  Show
                  gilesp Peter Giles (Inactive) added a comment - Hey Corey, looks like this went into trunk instead of rice-2.2. Hopefully I didn't tell you to do that (which I very well may have), but in any case, a reminder to keep an eye on the fix version
                  Hide
                  Permalink
                  gilesp Peter Giles (Inactive) added a comment -

                  I merged this down to 2.2.

                  Show
                  gilesp Peter Giles (Inactive) added a comment - I merged this down to 2.2.

                    People

                    • Assignee:
                      cpedersen Corey Pedersen (Inactive)
                      Reporter:
                      gilesp Peter Giles (Inactive)
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      3 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: