Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-9358

Form and WorkflowDocument no longer being persisted to session after disabling the SessionDocumentService

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.3
    • Fix Version/s: 2.1.6, 2.2.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KNS
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      There were some behaviors that the SessionDocumentService was responsible for besides storing the document to the database, and since we replaced it with a NoOp version, we noticed a couple of side effects: the form and the WorkflowDocument are no longer being kept in the session between requests. While things seem to be pretty much working with this behavior change, it is probably too risky for our patch version.

      The plan is to restore this behavior, hopefully without depending on the SessionDocumentService for it.

        Attachments

          Issue Links

            Activity

            Hide
            gilesp Peter Giles (Inactive) added a comment -

            Debugging what was going on in the UserSession today, the I found that the form was in fact being held in session, it just wasn't being done by the SessionDocumentService. I also chatted with Jonathan about what UC Davis did with their SessionDocumentService override, and it turns out that their implementation looked just like our NoOpSessionDocumentServiceImpl.

            Bearing that in mind, I think I will take the approach of restoring the behavior of keeping the WorkflowDocument in session as well without restoring the old SessionDocumentServiceImpl. We'll see how that goes anyway.

            Show
            gilesp Peter Giles (Inactive) added a comment - Debugging what was going on in the UserSession today, the I found that the form was in fact being held in session, it just wasn't being done by the SessionDocumentService. I also chatted with Jonathan about what UC Davis did with their SessionDocumentService override, and it turns out that their implementation looked just like our NoOpSessionDocumentServiceImpl. Bearing that in mind, I think I will take the approach of restoring the behavior of keeping the WorkflowDocument in session as well without restoring the old SessionDocumentServiceImpl. We'll see how that goes anyway.
            Hide
            gilesp Peter Giles (Inactive) added a comment -

            At the KTI today we agreed to preserve the stashing of WorkflowDocuments in the UserSession. To minimize the impact in 2.1.6, the fix there will be done in the minimally invasive way. In 2.3 we'll plan to address this by making the workflow document field on the document header non-transient, and remove all specific logic for storing and fetching the workflow document from the session since the form (which contains the document with its header) is stored in the session as well.

            Show
            gilesp Peter Giles (Inactive) added a comment - At the KTI today we agreed to preserve the stashing of WorkflowDocuments in the UserSession. To minimize the impact in 2.1.6, the fix there will be done in the minimally invasive way. In 2.3 we'll plan to address this by making the workflow document field on the document header non-transient, and remove all specific logic for storing and fetching the workflow document from the session since the form (which contains the document with its header) is stored in the session as well.

              People

              • Assignee:
                gilesp Peter Giles (Inactive)
                Reporter:
                gilesp Peter Giles (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: