Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-9614

Dialogs not correctly returning to controller method


    • Type: Bug Fix
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Backlog
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
    • Rice Module:
    • KRAD Feature Area:
      UIF Component
    • Application Requirement:
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:


      Actually, I'm wrong, sorry. It behaves very same way....
      (just refreshed the page, so I didn't notice it's still there).

      So yeah, problem is there.

      On Fri, May 24, 2013 at 9:09 AM, Valeriya Gadiyak <vgadiyak@gmail.com> wrote:

      Hi Jerry,
      I did some more digging. It's really odd, but looks like the redirect (from UifControllerBase.returnFromLightbox) doesn't do a trick. redirectURL =
      however it doesn't care for "methodToCall".
      I override returnFromLightbox to "return getUIFModelAndView" instead of "return performRedirect" and it works perfectly fine.
      Any ideas why is that?


      So my main question (I guess ) is why it doesn't go to the controller after I click "Delete" for the dialog (like it does for other cases)?

      Thank you!

      On Thursday, May 23, 2013 10:56:06 AM UTC-4, vgad...@gmail.com wrote:

      I looked here if it was asked before, and it seems to be similar to https://groups.google.com/a/kuali.org/forum/?fromgroups#!searchin/rice.usergroup.krad/dialog/rice.usergroup.krad/KXAtqKeXEgQ/rfMMDL7TOmAJ

      When I'm trying to delete draft I'm sent to dialog, but when I hit "Delete" in a dialog I return back to the original page, and draft is still there. Now if I click "Delete Draft" again I don't have dialog anymore, BUT draft gets deleted. I did debug, and looks like when I click "Delete Draft" first it goes through dialog, but doesn't go back to the controller. When I click "Delete Draft" 2nd time hasDialogBeenDisplayed(dialog, academicCalendarForm) is already satisfied, so it just proceeds to the rest of the controller.

      I tried to debug other "delete" we have for ACAL, and it worked. The only difference was in UifControllerBase,showDialog my form is Ajax Request, while other is not.

      Any ideas?


      public ModelAndView deleteTerm(@ModelAttribute("KualiForm") AcademicCalendarForm academicCalendarForm, BindingResult result,
      HttpServletRequest request, HttpServletResponse response) {

      String dialog = CalendarConstants.ACADEMIC_DELETE_CONFIRMATION_DIALOG;
      if (!hasDialogBeenDisplayed(dialog, academicCalendarForm))

      { //redirect back to client to display lightbox return showDialog(dialog, academicCalendarForm, request, response); }

      boolean confirmDelete = getBooleanDialogResponse(dialog, academicCalendarForm, request, response);

      { return getUIFModelAndView(academicCalendarForm); }

      } else

      { //redirect back to client to display lightbox return showDialog(dialog, academicCalendarForm, request, response); }


      int selectedLineIndex = KSControllerHelper.getSelectedCollectionLineIndex(academicCalendarForm);



      <property name="dialogs">
      <ref bean="KS-AcademicCalendar-ConfirmDelete-Dialog"/>
      <ref bean="KS-AcademicTerm-ConfirmDelete-Dialog"/>

      <bean id="KS-AcademicTerm-ConfirmDelete-Dialog" parent="Uif-DialogGroup" >
      <property name="renderHeader" value="false"/>
      <property name="promptText"
      value="Are you sure you want to delete the Academic Term?"/>
      <property name="availableResponses">
      <bean parent="Uif-KeyLabelPair" p:key="yes" p:value="Delete"/>
      <bean parent="Uif-KeyLabelPair" p:key="no" p:value="Cancel"/>


          Issue Links


            jkneal Jerry Neal (Inactive) created issue -
            jkneal Jerry Neal (Inactive) made changes -
            Field Original Value New Value
            Link This issue is related to KSENROLL-5767 [ KSENROLL-5767 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.4 [ 16913 ]
            Fix Version/s 2.3 [ 16595 ]
            Fix Version/s 2.3.0-m3 [ 16758 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.4-backlog [ 16596 ]
            Fix Version/s 2.4 [ 16913 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            masargen Matt Sargent made changes -
            Documentation Review Status Pending Review [ 14643 ] Not Required [ 14642 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 199381 ] Copy of custom for rice [ 208030 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow Copy of custom for rice [ 208030 ] custom [ 217778 ]
            spatterson Shem Patterson (Inactive) made changes -
            Workflow custom [ 217778 ] Rice Workflow [ 227526 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s 2.4 [ 16913 ]
            Fix Version/s 2.4-backlog [ 16596 ]
            jcoltrin Jessica Coltrin (Inactive) made changes -
            Fix Version/s Backlog [ 15811 ]
            Fix Version/s 2.4 [ 16913 ]
            ewestfal Eric Westfall made changes -
            Labels Old


              • Assignee:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                2 Start watching this issue


                • Created: