Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      UIF Component
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      As part of the new theme work we want to add support for LESS: http://lesscss.org/. In order to use LESS the files need compiled to CSS. We would like this to be integrated into the maven build process (similar to how minification is done).

      There are a few maven plugins out there. Search for 'LESS maven plugin'. Take a look through these and see which looks the best.

      Next we'll need to add the plugin to the krad-web pom. This is where the minify plugin is currently at.

      What we would like to happen is for the plugin to pick up any '.less' files under the web /themes folder. Compile each found file to '.css' in the directory. If we need to be more specific about paths that would be ok, but it would be nice if we could keep it generic like this.

      To test, just create a .less file somewhere in /themes, and verify the .css file is created when we build krad-web

        Attachments

          Issue Links

            Activity

            Hide
            cpedersen Corey Pedersen (Inactive) added a comment -

            Jerry: If we are going to add a stylesheets directory for theme less files we should change he excludes.

                <excludes>
                    <exclude>bootstrap/less/*.less</exclude>
                </excludes>
            
            Show
            cpedersen Corey Pedersen (Inactive) added a comment - Jerry: If we are going to add a stylesheets directory for theme less files we should change he excludes. <excludes> <exclude>bootstrap/less/*.less</exclude> </excludes>
            Hide
            cpedersen Corey Pedersen (Inactive) added a comment -

            Jerry: Did I misunderstand? "1) Move bootstrap install to themes folder so it can be inherited from"

            Are you saying that to allow bootstrap to be inherited from the structure be:

            /themes
               /bootstrap
                   /kboot
                       /images
                       /scripts
                       /stylesheets
                       /themes.less
                       /variables.less
                   /kns-theme
                       ....
                   /ks-theme
                       ....
                   /less
                   /js
                   /img
                   /docs     
            
            Show
            cpedersen Corey Pedersen (Inactive) added a comment - Jerry: Did I misunderstand? "1) Move bootstrap install to themes folder so it can be inherited from" Are you saying that to allow bootstrap to be inherited from the structure be: /themes /bootstrap /kboot /images /scripts /stylesheets /themes.less /variables.less /kns-theme .... /ks-theme .... /less /js /img /docs
            Hide
            cpedersen Corey Pedersen (Inactive) added a comment -

            Update of themes.less for new structure

            // Core variables and mixins
            @import  "variables.less"; // Modify this for custom colors, font-sizes, etc
            
            @import  "../bootstrap/less/mixins.less";
            ....
            
            Show
            cpedersen Corey Pedersen (Inactive) added a comment - Update of themes.less for new structure // Core variables and mixins @ import "variables.less" ; // Modify this for custom colors, font-sizes, etc @ import "../bootstrap/less/mixins.less" ; ....
            Hide
            cpedersen Corey Pedersen (Inactive) added a comment - - edited

            Jerry: One question is that if we use the lesscss compiler there is the <compress>true</compress> feature. It is not exactly the same as minify, but close. It strips all unneeded comments and space out, but leaves the lines separate. So you get most of the benefit of space compaction on the produced css files, but they are still somewhat readable.

            Show
            cpedersen Corey Pedersen (Inactive) added a comment - - edited Jerry: One question is that if we use the lesscss compiler there is the <compress>true</compress> feature. It is not exactly the same as minify, but close. It strips all unneeded comments and space out, but leaves the lines separate. So you get most of the benefit of space compaction on the produced css files, but they are still somewhat readable.
            Hide
            jcoltrin Jessica Coltrin (Inactive) added a comment -

            According to Jerry, this is done, so I'm resolving.

            Show
            jcoltrin Jessica Coltrin (Inactive) added a comment - According to Jerry, this is done, so I'm resolving.

              People

              • Assignee:
                cpedersen Corey Pedersen (Inactive)
                Reporter:
                jkneal Jerry Neal (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: