Uploaded image for project: 'Kuali Rice Development'
  1. Kuali Rice Development
  2. KULRICE-9916

Do checkbox conversion in LookupInputField only when specified through attribute definition

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: Development
    • Security Level: Public (Public: Anyone can view)
    • Labels:
      None
    • Rice Module:
      KRAD
    • KRAD Feature Area:
      Lookup
    • Application Requirement:
      Rice
    • KAI Review Status:
      Not Required
    • KTI Review Status:
      Not Required
    • Code Review Status:
      Not Required
    • Include in Release Notes?:
      Yes

      Description

      For LookupInputField convert the checkboxes only when it comes from the attribute definition.

      Jerry's request/observation:

      It seems we only do the textarea control conversion if it comes from the attribute definition, but we convert checkboxes in all cases. Is there a reason for the difference? It makes sense to me that we only convert controls if it comes from the AttributeDefinition. If they set the control explicitly on the field, we should probably just allow it.

      Jerry also suggest the following improvement:

      For converting from the checkbox to the radio group. We inject the radio group for one case, and build it using the component factory in another case. I would just build a bean for the radio group with a set id, then if it is determined you need to convert the control call the component factory to get that bean by id. That way it is configured in the XML, but we only get it if needed.

        Attachments

          Issue Links

            Activity

            There are no comments yet on this issue.

              People

              • Assignee:
                cniesen Claus Niesen
                Reporter:
                cniesen Claus Niesen
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: