[KULRICE-11529] Consolidate and simplify ID generation logic Created: 23/Dec/13 Updated: 21/May/15 Resolved: 31/Jan/14
|Project:||Kuali Rice Development|
|Fix Version/s:||Not version specific|
|Security Level:||Public (Public: Anyone can view)|
|Reporter:||Jerry Neal (Inactive)||Assignee:||Mark Fyffe (Inactive)|
|Remaining Estimate:||0 minutes|
|Time Spent:||1 day|
|Original Estimate:||4 hours|
|KRAD Feature Area:||
|KAI Review Status:||Not Required|
|KTI Review Status:||Not Required|
|Code Review Status:||Not Required|
|Include in Release Notes?:||
Cleanup item moved from
Extract ID assignment code (org.kuali.rice.krad.uif.service.impl.ViewHelperServiceImpl#preprocessView) to helper method or class, along with Component State, Create helper methods to reduce nesting and duplicate code
|Comment by Mark Fyffe (Inactive) [ 27/Dec/13 ]|
This work is complete on the performance branch. Unit tests have been updated and are passing, and initial regression testing didn't turn over any issues.
Note that strict mode is not slower due to path/element verification, so should be disabled in non-development environments (if not already).
|Comment by Mark Fyffe (Inactive) [ 28/Dec/13 ]|
Reopening for further simplification based on items below from Jerry. To address this, I am converting sub-lifecycle spawning to be automatically and eliminating the need to explicitly spawn when components are dynamically added to the graph.
Another small item related to this request, since it pertains to AssignIdsTask:
|Comment by Mark Fyffe (Inactive) [ 29/Dec/13 ]|
Removed spawnSubLifecycle and completed regression testing in KRAD sampleapp.
Spawning sub-lifecycle phases for components that are not yet at the required lifecycle phase is now automated as part of the initializeSuccessors implementation in InitializeComponentPhase, ApplyModelComponentPhase, and FinalizeComponentPhase.
In regression testing, it was noted that ActionField duplicates properties from Action, which resulted in duplicated lifecycle processing for some pages. Also, it was noted that TreeGroup needed to have bean properties added to support the original getComponentsForLifecycle() and getComponentPrototypes() behavior.
|Comment by Mark Fyffe (Inactive) [ 27/Jan/14 ]|
Reopened temporarily pending code review during F2F.
Renamed LifecycleElementState#getPath() to #getParentPath()
Double-checked unit tests and KRAD sampleapp