[KULRICE-14037] Apply Jonathan's patch for KFSMI-3654 to 2.1.x code line Created: 18/Nov/14  Updated: 02/Sep/15  Resolved: 08/Dec/14

Status: Closed
Project: Kuali Rice Development
Component/s: Development
Affects Version/s: None
Fix Version/s: None
Security Level: Public (Public: Anyone can view)

Type: Task Priority: Critical
Reporter: James Smith Assignee: Jonathan Keller
Resolution: Fixed Votes: 0
Labels: 201411Requests
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File rice_qualifier_dedupe.patch    
Issue Links:
Cloners
cloned to KULRICE-14099 Eliminate duplicate workflow qualifie... Open
Relate
relates to KULRICE-14252 Reapply finished KFS backlog jiras Open
Epic Link: KFS Backlog
Rice Module:
KEW
Application Requirement:
KFS
KAI Review Status: Not Required
KTI Review Status: Not Required
Code Review Status: Not Required
Include in Release Notes?:
Yes

 Description   

Jonathan should have a fix for KFSMI-3654; we just need it applied to Rice.



 Comments   
Comment by Claus Niesen [ 26/Nov/14 ]

Jonathan, can you attach the patch?

Comment by Jonathan Keller [ 05/Dec/14 ]

Not as easy as that due to the fact that it was done against KFS. I'm extracting the pieces into a Rice 2.1 branch and then will rebuild a proper patch file.

Comment by Claus Niesen [ 05/Dec/14 ]

Thanks

Comment by Jonathan Keller [ 05/Dec/14 ]

Here's the patch - it was only 2 files.

Comment by James Smith [ 05/Dec/14 ]

Cool, thank you Jonathan!

Comment by Claus Niesen [ 08/Dec/14 ]

Jonathan, we need to patch Rice 2.2 through 2.5 as well. BTW, did you intend to commit the eclipse files?

Comment by Jonathan Keller [ 08/Dec/14 ]

Yes, I did. I spent more time fighting to try not to include them and generate a patch file which I could re-use. After an hour of that I just checked the files in so I can work in Rice without the overhead of reconfiguring every time.

As for the other branches - no I have not. I wasn't sure what the process was for that. Manual? Or merge of the 2.1 branch changes forward to the next one?

Comment by Claus Niesen [ 08/Dec/14 ]

Manual merging is probably best.

Comment by Jonathan Keller [ 09/Dec/14 ]

Yea - it may take a little to merge it. I realized (after pushing it to 2.1) that I have no way to test it. There is nothing in the KEW integration tests or sample applications which would exercise this code. It's identical to what we have in production at UCD, but I'm not comfortable pushing a change to 4 versions of Rice without some assurance that there is not something stupid in there which might break workflow.

Now, this is not a blocker from a system operation standpoint. So, do you want me spending my time on that, or integrating into 2.5 only? I figure it will take a number of hours to figure out how to get the needed data and DD files set up within the integration test framework to test this properly.

Comment by Jonathan Keller [ 09/Dec/14 ]

Per discussion - will check in code to 2.1 branch and resolve this JIRA. A new JIRA will be opened to apply the changes to the other Rice versions after KFS has had a chance to test the results.

Comment by Claus Niesen [ 02/Sep/15 ]

This change was rolled back. See KULRICE-14252 for instructions to reapply.

Generated at Sat Nov 28 02:44:55 CST 2020 using JIRA 7.0.11#70121-sha1:19d24976997c1d95f06f3e327e087be0b71f28d4.