[KULRICE-2649] Verify that our jsps and tag libraries are using quotes properly and work successfully in Tomcat 5.5.27 Created: 11/Feb/09  Updated: 17/Aug/09  Resolved: 22/Apr/09

Status: Closed
Project: Kuali Rice Development
Component/s: Application Server
Affects Version/s: None
Fix Version/s: 1.0

Type: Task Priority: Major
Reporter: Eric Westfall Assignee: Srikanth Mummadi (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Rely
relies on KULRICE-2607 Test the standalone war Closed
relies on KULRICE-2764 Deploy Rice standalone server to our ... Closed

 Description   

See the following Tomcat bug report for details of what we need to verify

https://issues.apache.org/bugzilla/show_bug.cgi?id=45015



 Comments   
Comment by Eric Westfall [ 27/Feb/09 ]

Srikanth, for this one I would first like you to do the research to determine if we have any jsps or tag libraries that have the issue described in the link. If you find some, create a list of them and we can work on the next step of addressing the problem.

All of our jsps and tag libraries are located under the "web" maven module in the project.

Comment by Srikanth Mummadi (Inactive) [ 04/Mar/09 ]

I have found the following two JSP pages are using quotes improperly.
1. KualiExceptionIncident.jsp
2. ShowHideButton.jsp
Tomcat 5.5.27 installation will be done after security approvals which will take some time.

Comment by Srikanth Mummadi (Inactive) [ 04/Mar/09 ]

I have installed Tomcat 5.5.27 on my machine.

Comment by Srikanth Mummadi (Inactive) [ 04/Mar/09 ]

I tried to deploy rice-web-0.9.4-SNAPSHOT.war created in RICE 0.9.4\rice-0.9.4\web\target folder on Tomcat 5.5.27, But the server fails to start. Is there any other configuration needed to deploy Rice on Tomcat.

Comment by Srikanth Mummadi (Inactive) [ 05/Mar/09 ]

I have created the "rice-0.9.4-SNAPSHOT-server.war" file by running the Ant dist-server command.

Created a copy of common-config.xml in <home dir>\kuali\main\dev and named it as rice-config.xml.

I copied the following configurations from sample-app-config.xml to common-config.xml.

<param name="application.url">http://172.25.27.81:8080/$

{app.context.name}

</param>
<param name="workflow.url">$

{application.url}/en</param>
<param name="notification.basewebappurl">${application.url}

/ken</param>
<param name="kr.url">$

{application.url}/kr</param>
<param name="serviceServletUrl">${application.url}

/remoting/</param>

<param name="keystore.alias">rice</param>
<param name="keystore.password">r1c3pw</param>
<param name="keystore.file">$

{basedir}\src\test\resources\keystore\ricekeystore</param>
<param name="keystore.location">${basedir}

\src\test\resources\keystore\ricekeystore</param>

In Standalone-config.xml modified
<param name="config.location">/usr/local/rice/rice-config.xml</param>
to
<param name="config.location">C:/Documents and Settings/SM21485/kuali/main/dev/rice-config.xml</param>

Common-config-defaults.xml
<param name="security.directory" override="false">/usr/local/rice/</param>
to
<param name="security.directory" override="false">C:/Documents and Settings/SM21485/kuali/main/dev/</param>

I am getting the following error when I try to deploy "rice-0.9.4-SNAPSHOT-server.war" in Tomcat.

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rice' defined in class path resource [org/kuali/rice/config/RiceSpringBeans.xml]: Invocation of init method failed; nested exception is java.io.FileNotFoundException: class path resource [log4j.properties] cannot be resolved to absolute file path because it does not reside in the file system: jar:file:/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%205.5/webapps/rice-0.9.4-SNAPSHOT-server/WEB-INF/lib/bsf-2.4.0.jar!/log4j.properties

Comment by Eric Westfall [ 05/Mar/09 ]

Srikanth, Casey's currently working on a deployment of standalone Rice to our test servers. As part of that process he should hopefully be running across any issues and working them out. Once that is complete is probably when we should go ahead and try deploying a Rice standalone server to Tomcat 5.5.27 to check this out. I'll link the two jira issues together. In the meantime i'll find another task to assign you to and you can come back to this one when the standalone rice deployment issues have been worked out.

Comment by Jeremy Hanson [ 26/Mar/09 ]

In the bugzilla link there is a nice regular expression to find instances of these problems.

<\w+:[^>]="[^<"]<%=[^%]"|<\w:[^>]+='[^<']<%=[^%]'

I ran this and there are currently only two places in all jsp and tag files that need to be updated.

Row 29 of KualiExceptionIncident.jsp
– should be changed to:
value='<%=request.getAttribute("org.kuali.rice.kns.web.struts.action.KualiExceptionHandlerAction")%>' />
and
Row 670 of rowDisplay.tag
– should be changed to:
<c:out value='<%=((String) request.getAttribute("fileName"))%>' /> 

Comment by Eric Westfall [ 26/Mar/09 ]

Initial version has been deployed to maven repository and weekly deployments are in place on Friday's at 4 in continuum.

Comment by Srikanth Mummadi (Inactive) [ 27/Mar/09 ]

I am still getting the following error when I try to deploy "rice-0.9.4-SNAPSHOT-server.war" in Tomcat.

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rice' defined in class path resource [org/kuali/rice/config/RiceSpringBeans.xml]: Invocation of init method failed; nested exception is java.io.FileNotFoundException: class path resource [log4j.properties] cannot be resolved to absolute file path because it does not reside in the file system: jar:file:/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%205.5/webapps/rice-0.9.4-SNAPSHOT-server/WEB-INF/lib/bsf-2.4.0.jar!/log4j.properties

But I tested rowDisplay.tag in KFS 1092 build, but it throws the following exception

org.apache.jasper.JasperException: /WEB-INF/tags/kr/rowDisplay.tag(670,26) Attribute value ((String) request.getAttribute("fileName")) is quoted with " which must be escaped when used within the value

I corrected this file and checked in.
For KualiExceptionIncident.jsp, I could not generate Exception condition in KFS so could not test/change it.

Comment by Eric Westfall [ 22/Apr/09 ]

Thanks Srikanth and Jeremy. I went ahead and fixed this in the incident report as well.

Comment by Eric Westfall [ 17/Aug/09 ]

Bulk change of all Rice 1.0 issues to closed after public release.

Generated at Wed Sep 30 12:35:26 CDT 2020 using JIRA 7.0.11#70121-sha1:19d24976997c1d95f06f3e327e087be0b71f28d4.