[KULRICE-3356] "Travel Account" field on Travel Request creation page is not working properly Created: 13/Jul/09  Updated: 03/Oct/14  Resolved: 23/Jul/09

Status: Closed
Project: Kuali Rice Development
Component/s: Quality Assurance, User Interface
Affects Version/s: None
Fix Version/s: 1.0

Type: Bug Fix Priority: Major
Reporter: Chad Hagstrom Assignee: Chad Hagstrom
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Similar issues:
KULRICE-7389Travel Account Lookup page not rendering in IE (9)
KULRICE-11997Travel Account Inquiry with Collections not rendering
KULRICE-13768Create AFT for Travel Account Bulk Update
KULRICE-12852Direct inquiry icon is not appearing for sub account on travel account maintenance document
KULRICE-10615Able to add accounts to travel request when logged in as initiator
KULRICE-7848Travel Account Document has a NPE on empty subsidized percent
KULRICE-7191No validation on account numbers of Travel Maint document
KULRICE-8544Travel Account Maintenance (New) Document: Account Number issues
KULRICE-12434Create Travel Account Lookup with advanced features
KULRICE-14044JS Error on Travel Account Maintenance Ad Hoc Requests person lookup
Rice Team: QA

 Description   

On the Travel Request creation page, I've noticed several problems with the "Travel Account" field. First, if the user clicks the lookup link on the field and then either clicks "cancel" or returns a value from the lookup, the iframe shows a blank white page. This problem also occurs if the user opens the field's direct inquiry link with Javascript disabled and then clicks "close". I believe the problem lies with the fact that TravelDocumentAction2.refresh simply does nothing other than returning null, so this method needs to be implemented appropriately.

Another problem with the "Travel Account" field is the list of accounts that it maintains. Whenever the user clicks "add", a new item is added to the list regardless of whether or not the text field is empty or contains invalid data. If the data is valid, the account appears to be properly added to the list; otherwise, a supposedly blank entry is added to the list, which can result in NullPointerException-induced HTTP 500 errors when saving or routing the document. In addition, there does not appear to be any way to remove list items once they have been placed in, and it is possible to include duplicate account entries.



 Comments   
Comment by Chad Hagstrom [ 17/Jul/09 ]

I've fixed the "Travel Account" field's problems mentioned above, so it should be working as expected now. However, I discovered one other odd detail that I wanted to get feedback on before resolving this issue. I noticed that the Travel Request creation page includes a drop-down for choosing a particular account type code, yet the "Travel Account" field allows users to add travel accounts of any type to its list, regardless of whether or not they conform to the selected type code. Is this intentional, or is there supposed to be some sort of validation in place to ensure that the added travel accounts have the proper code? Or is the drop-down intended for some other purpose?

Comment by Eric Westfall [ 23/Jul/09 ]

Hi Chad, I think the way it's implemented currently is fine. I'll go ahead and resolve this issue. Thanks!

Comment by Eric Westfall [ 17/Aug/09 ]

Bulk change of all Rice 1.0 issues to closed after public release.

Generated at Wed Jul 15 00:11:10 CDT 2020 using JIRA 6.1.5#6160-sha1:a61a0fc278117a0da0ec9b89167b8f29b6afdab2.