[KULRICE-4805] DocumentTypePermissionServiceImpl seems to build permission details incorrectly Created: 03/Nov/10  Updated: 09/Sep/11  Resolved: 28/Jan/11

Status: Closed
Project: Kuali Rice Development
Component/s: Development
Affects Version/s: None
Fix Version/s: 1.0.3.1

Type: Bug Fix Priority: Major
Reporter: Jonathan Keller Assignee: William Balderamos (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Discovered
discovered by KFSOLD-20128 in KC, account creation creates a mai... Closed
Rice Module:
KEW
KAI Review Status: Not Required
KTI Review Status: Not Required

 Description   

I'm not sure if this is a problem or not, but it seems inconsistent. Look at the code below. When the document is not in I or S state, it puts the route status label into the route node detail type. It seems like this is mixing things a little. Shouldn't it be using the current route node name like the buildDocumentTypePermissionDetails() method below it?

protected AttributeSet buildRouteHeaderIdRoleDocumentTypeDocumentStatusQualifiers(DocumentType documentType, String documentStatus, String routeHeaderId) {
AttributeSet qualifiers = new AttributeSet();
qualifiers.put(KimAttributes.DOCUMENT_NUMBER, routeHeaderId);
if (!StringUtils.isBlank(documentStatus)) {
qualifiers.put(KEWConstants.DOCUMENT_STATUS_DETAIL, documentStatus);
if (KEWConstants.ROUTE_HEADER_INITIATED_CD.equals(documentStatus) || KEWConstants.ROUTE_HEADER_SAVED_CD.equals(documentStatus))

{ qualifiers.put(KimAttributes.ROUTE_NODE_NAME, DocumentAuthorizerBase.PRE_ROUTING_ROUTE_NAME); }

else

{ qualifiers.put(KimAttributes.ROUTE_NODE_NAME, CodeTranslator.getRouteStatusLabel(documentStatus)); }

}



 Comments   
Comment by Jessica Coltrin (Inactive) [ 23/Nov/10 ]

should be trivial, but needs KTI review.

Comment by William Balderamos (Inactive) [ 25/Jan/11 ]

See revision #15488.

Comment by William Balderamos (Inactive) [ 26/Jan/11 ]

See revision #15506.

Comment by William Balderamos (Inactive) [ 27/Jan/11 ]

Reopening for code review changes.

Comment by William Balderamos (Inactive) [ 28/Jan/11 ]

See revision #15540.
Also see code review http://fisheye.kuali.org/cru/rice-19.

Comment by William Balderamos (Inactive) [ 28/Jan/11 ]

After code review, changes look good.

Comment by Jessica Coltrin (Inactive) [ 09/Sep/11 ]

closing since 1.0.3.1 is released.

Generated at Tue Aug 04 06:20:58 CDT 2020 using JIRA 7.0.11#70121-sha1:19d24976997c1d95f06f3e327e087be0b71f28d4.