[KULRICE-5363] Inquiry - Support for displaying bo attachments and downloading Created: 14/Jul/11 Updated: 24/Sep/14 Resolved: 26/Aug/14
|Project:||Kuali Rice Development|
|Component/s:||Development, KNS Equivalency, Roadmap|
|Security Level:||Public (Public: Anyone can view)|
|Reporter:||Jerry Neal (Inactive)||Assignee:||Shannon Hess|
|Remaining Estimate:||0 minutes|
|Time Spent:||2 days, 2 hours|
|Original Estimate:||2 days|
|Attachments:||Inquiry screen with download.jpg|
|KRAD Feature Area:||
|Sprint:||Core 2.5.0-m6 Sprint 2|
|KAI Review Status:||Not Required|
|KTI Review Status:||Not Required|
|Include in Release Notes?:||
As a user of inquiries, I want to be able to see and download attachments from the inquiry view (both attachments associated with the doc and those associated with the BO), so that I can access the attachments without having to edit the doc.
Inquiries in KRAD need support for displaying bo attachments on the inquiry and allowing them to be downloaded.
There are two ways of downloading attachments from inquiries: from something of type PersistableAttachment or PersistableAttachmentList, and from custom parameters. The KNS code for the first can be found in KualiInquiryAction.downloadAttachment, and the KNS code for the second can be found in KualiInquiryAction.downloadCustomBOAttachment. The first is very much like what we do with maintenance documents, as seen in MaintenanceDocumentControllerServiceImpl. The second just takes raw parameters and allows the download based on those parameters.
These two methods need to be integrated into the InquiryController and InquiryControllerServiceImpl just like they are in maintenance. The first method should be renamed to downloadDataObjectAttachment and the second method should be renamed to downloadCustomDataObjectAttachment for consistency. We should probably keep these separate for now.
Also update the KNS2KRAD upgrade guide to show how to convert KNS to KRAD. Create a pre-commit code review as well.
|Comment by Jessica Coltrin (Inactive) [ 08/Nov/11 ]|
double-tagging with 2.0.0-b3 for review.
|Comment by Kristina Taylor (Inactive) [ 01/Oct/13 ]|
I'm not really sure this was ever really used anywhere or even properly implemented. I couldn't find any examples in Fisheye in Inquiries specifically, and I couldn't find how it could work in the KNS. I think this is perhaps a desired feature in the long run but it may not be as critical as others. It would be easier to actually implement this feature after fixing
|Comment by Kristina Taylor (Inactive) [ 17/Jul/14 ]|
See additional comments on
|Comment by Shannon Hess [ 14/Aug/14 ]|
From work log: Investigated how this works on KNS. Got it mostly working on KRAD but I need to work out the bugs, test collection attachments, create an AFT, and create documentation.
Attaching the inquiry screen with a download. The description does not like the word "I'm"
|Comment by Shannon Hess [ 21/Aug/14 ]|
I've created a fisheye review for Kristina, Jerry, and Dan. https://fisheye.kuali.org/cru/rice-473 I left it open in case anyone else would like to view the changes.
Still left todo: update the KNS2KRAD upgrade guide to show how to convert KNS to KRAD.
|Comment by Shannon Hess [ 21/Aug/14 ]|
To test downloadCustomDataObjectAttachment I created a second inquiry view called customDataObject for LabsTravelAttachment. It passes the fileName, contentType, and fileContentDataObjectField when the "download custom attachment" button is selected.
Link to Inquiry Test view - http://localhost:8080/krad-dev/kr-krad/kradsampleapp?viewId=KradInquirySample-PageR6C3
Altered inquiry link to test downloadCustomDataObjectAttachment code - http://localhost:8080/krad-dev/kr-krad/inquiry?travelAttachmentGroupNumber=123&methodToCall=start&dataObjectClassName=org.kuali.rice.krad.labs.LabsTravelAttachment&id=attachment14085ay561744&viewName=customDataObject
|Comment by Shannon Hess [ 26/Aug/14 ]|
The tests failed in CI due to me not switching back to the needed file location – I've committed the fix for that. Here is the location of the tests for future reference:
I'm going to go ahead and close this issue, but I'll still verify the tests pass during their next CI run.